Override the webrtc TaskQueue implementation.

Override the webrtc TaskQueue implementation.
Since user32.dll may not be used withing Chrome's sandbox on win 8 at later, we need to override the TaskQueue implementation. This implementation uses base::Thread and the SingleTreadedTaskRunner to post tasks to the queue.

BUG=webrtc:5687
NOTRY=true

Committed: https://crrev.com/e4eba5884297c0224b071a764dfa8a6236887747
Cr-Commit-Position: refs/heads/master@{#415275}

[perkj_chrome, 2016-08-30 10:01:06]

perkj@chromium.org changed reviewers:
+ tommi@chromium.org

[perkj_chrome, 2016-08-30 10:01:07]

please?

[tommi (sloooow) - chröme, 2016-08-30 11:49:25]

lgtm on the approach.  Will you split out the test to another cl or include it
here?

https://codereview.chromium.org/2291033002/diff/20001/third_party/webrtc_over...
File third_party/webrtc_overrides/webrtc/base/task_queue.cc (right):

https://codereview.chromium.org/2291033002/diff/20001/third_party/webrtc_over...
third_party/webrtc_overrides/webrtc/base/task_queue.cc:22: if (!task->Run()) {
nit: remove {}

https://codereview.chromium.org/2291033002/diff/20001/third_party/webrtc_over...
third_party/webrtc_overrides/webrtc/base/task_queue.cc:67: ~WorkerThread();
override?

[perkj_chrome, 2016-08-30 12:12:48]

On 2016/08/30 11:49:25, tommi (chrömium) wrote:
> lgtm on the approach.  Will you split out the test to another cl or include it
> here?
> 
>
https://codereview.chromium.org/2291033002/diff/20001/third_party/webrtc_over...
> File third_party/webrtc_overrides/webrtc/base/task_queue.cc (right):
> 
>
https://codereview.chromium.org/2291033002/diff/20001/third_party/webrtc_over...
> third_party/webrtc_overrides/webrtc/base/task_queue.cc:22: if (!task->Run()) {
> nit: remove {}
> 
>
https://codereview.chromium.org/2291033002/diff/20001/third_party/webrtc_over...
> third_party/webrtc_overrides/webrtc/base/task_queue.cc:67: ~WorkerThread();
> override?

It will have to be done in a separate cl after we have rolled in usage of these
overrides in webrtc.

[perkj_chrome, 2016-08-30 12:19:10]

https://codereview.chromium.org/2291033002/diff/20001/third_party/webrtc_over...
File third_party/webrtc_overrides/webrtc/base/task_queue.cc (right):

https://codereview.chromium.org/2291033002/diff/20001/third_party/webrtc_over...
third_party/webrtc_overrides/webrtc/base/task_queue.cc:22: if (!task->Run()) {
On 2016/08/30 11:49:24, tommi (chrömium) wrote:
> nit: remove {}

Done.

https://codereview.chromium.org/2291033002/diff/20001/third_party/webrtc_over...
third_party/webrtc_overrides/webrtc/base/task_queue.cc:67: ~WorkerThread();
On 2016/08/30 11:49:24, tommi (chrömium) wrote:
> override?

Done.

[perkj_chrome, 2016-08-30 12:19:43]

Description was changed from

==========
Override the webrtc TaskQueue implementation.
Since user32.dll may not be used withing Chrome's sandbox on win 8 at later, we
need to override the TaskQueue implementation. This implementation uses
base::Thread and the SingleTreadedTaskRunner to post tasks to the queue.


BUG=webrtc:5687
==========

to

==========
Override the webrtc TaskQueue implementation.
Since user32.dll may not be used withing Chrome's sandbox on win 8 at later, we
need to override the TaskQueue implementation. This implementation uses
base::Thread and the SingleTreadedTaskRunner to post tasks to the queue.


BUG=webrtc:5687
NOTRY=true
==========

[perkj_chrome, 2016-08-30 12:20:18]

The CQ bit was checked by perkj@chromium.org

[perkj_chrome, 2016-08-30 12:20:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2291033002/#ps40001
(title: "Revert content_tests.gypi for now.")

[commit-bot: I haz the power, 2016-08-30 12:20:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 12:23:53]

Description was changed from

==========
Override the webrtc TaskQueue implementation.
Since user32.dll may not be used withing Chrome's sandbox on win 8 at later, we
need to override the TaskQueue implementation. This implementation uses
base::Thread and the SingleTreadedTaskRunner to post tasks to the queue.


BUG=webrtc:5687
NOTRY=true
==========

to

==========
Override the webrtc TaskQueue implementation.
Since user32.dll may not be used withing Chrome's sandbox on win 8 at later, we
need to override the TaskQueue implementation. This implementation uses
base::Thread and the SingleTreadedTaskRunner to post tasks to the queue.


BUG=webrtc:5687
NOTRY=true
==========

[commit-bot: I haz the power, 2016-08-30 12:23:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-30 12:25:23]

Description was changed from

==========
Override the webrtc TaskQueue implementation.
Since user32.dll may not be used withing Chrome's sandbox on win 8 at later, we
need to override the TaskQueue implementation. This implementation uses
base::Thread and the SingleTreadedTaskRunner to post tasks to the queue.


BUG=webrtc:5687
NOTRY=true
==========

to

==========
Override the webrtc TaskQueue implementation.
Since user32.dll may not be used withing Chrome's sandbox on win 8 at later, we
need to override the TaskQueue implementation. This implementation uses
base::Thread and the SingleTreadedTaskRunner to post tasks to the queue.

BUG=webrtc:5687
NOTRY=true

Committed: https://crrev.com/e4eba5884297c0224b071a764dfa8a6236887747
Cr-Commit-Position: refs/heads/master@{#415275}
==========

[commit-bot: I haz the power, 2016-08-30 12:25:24]

Patchset 3 (id:??) landed as
https://crrev.com/e4eba5884297c0224b071a764dfa8a6236887747
Cr-Commit-Position: refs/heads/master@{#415275}

[perkj_chrome, 2016-08-30 12:41:46]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2297643003/ by perkj@chromium.org.

The reason for reverting is: Actually still breaks Android.....

[findit-for-me, 2016-08-30 12:43:59]

FYI: Findit try jobs (rerunning failed compile or tests) identified this CL
at revision 415275 as the culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...