Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2291013003: Make the Mojo ChromiumOS fyi bot release+dcheck. (Closed)

Created:
4 years, 3 months ago by msw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, sadrul, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the Mojo ChromiumOS fyi bot release+dcheck. We used debug (component builds) to workaround Issue 594674. Scott recently fixed mash browser tests for static builds with: https://codereview.chromium.org/2295433003/ Make the bot release again, but now with ozone+dchecks. It's TBD if we need more args to make mash work with ozone: ozone_auto_platforms = false ozone_platform_x11 = true BUG=639882, 642433 TEST=Mojo ChromiumOS fyi bot does release+dcheck builds. R=dpranke@chromium.org Committed: https://crrev.com/a17c267c6a457d280a75e8cd39aa39d6adcb58f3 Cr-Commit-Position: refs/heads/master@{#415448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
msw
Hey Dirk, please take a look; thanks!
4 years, 3 months ago (2016-08-30 19:13:31 UTC) #2
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-30 19:21:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291013003/1
4 years, 3 months ago (2016-08-30 19:34:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 21:59:03 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 22:02:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a17c267c6a457d280a75e8cd39aa39d6adcb58f3
Cr-Commit-Position: refs/heads/master@{#415448}

Powered by Google App Engine
This is Rietveld 408576698