Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2290993002: Always set presence/up from go tsmon apps. (Closed)

Created:
4 years, 3 months ago by dsansome
Modified:
4 years, 3 months ago
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Always set presence/up from go tsmon apps. BUG=642280 Committed: https://github.com/luci/luci-go/commit/eddd347821b8a2bfc4e94d04681d9d4c24b19fac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M appengine/tsmon/middleware.go View 1 chunk +0 lines, -1 line 0 comments Download
M common/tsmon/metric/metric_test.go View 2 chunks +2 lines, -9 lines 0 comments Download
M common/tsmon/metric/standard_metrics.go View 2 chunks +9 lines, -3 lines 0 comments Download
M common/tsmon/metric/standard_metrics_test.go View 2 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dsansome
4 years, 3 months ago (2016-08-30 08:10:48 UTC) #2
Vadim Sh.
lgtm
4 years, 3 months ago (2016-08-30 17:18:37 UTC) #3
Sergey Berezin
lgtm
4 years, 3 months ago (2016-08-30 18:12:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290993002/1
4 years, 3 months ago (2016-08-31 01:28:00 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 01:38:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/eddd347821b8a2bfc4e94d04681d9d4c24b19fac

Powered by Google App Engine
This is Rietveld 408576698