third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp - Issue 2290983003: CSSStyleSheetResource should cache decoded text instead of raw bytes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

Issue 2290983003: CSSStyleSheetResource should cache decoded text instead of raw bytes (Closed)

Patch Set: add dcheck Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

index 6369883c41a8dd0295c3f6754d87b6f363615d1f..6c87e43277c67149a826c3aa85035bc1bc9ae360 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

@@ -230,7 +230,8 @@ bool InspectorPageAgent::cachedResourceContent(Resource* cachedResource,

switch (cachedResource->getType()) {

case Resource::CSSStyleSheet:

maybeEncodeTextContent(

- toCSSStyleSheetResource(cachedResource)->sheetText(),

+ toCSSStyleSheetResource(cachedResource)

+ ->sheetText(CSSStyleSheetResource::MIMETypeCheck::Lax),

cachedResource->resourceBuffer(), result, base64Encoded);

return true;

case Resource::Script: