third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h - Issue 2290983003: CSSStyleSheetResource should cache decoded text instead of raw bytes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

Issue 2290983003: CSSStyleSheetResource should cache decoded text instead of raw bytes (Closed)

Patch Set: add dcheck Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

diff --git a/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h b/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

index 51ff8d9133f57ef9d5ccdc4a76b781fe502b1672..e113b2bf8460907d0953fc5411a276ae80f6cd39 100644

--- a/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

+++ b/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

@@ -79,10 +79,9 @@ class CORE_EXPORT CSSStyleSheetResource final : public StyleSheetResource {

void setParsedStyleSheetCache(StyleSheetContents*);

void destroyDecodedDataIfPossible() override;

- void destroyDecodedDataForFailedRevalidation() override {

- destroyDecodedDataIfPossible();

- }

+ void destroyDecodedDataForFailedRevalidation() override;

+ // Decoded sheet text cache is available iff loading this CSS resource is successfully complete.

String m_decodedSheetText;

Member<StyleSheetContents> m_parsedStyleSheetCache;