Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2290953002: Fix security icon colors on light themes (Closed)

Created:
4 years, 3 months ago by estark
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Fix security icon colors on light themes Security icon colors on Chrome for Android and Chrome Custom Tabs should be as follows: 1. Default toolbar color => green lock/red triangle 2. Dark toolbar color => white icons 3. Light toolbar color with opaque omnibox => green/red 4. Other toolbar color with transparent omnibox => dark icons BUG=633736 TEST=On Chrome for Android, visit the following URLs and observe the given security icon colors: 1. https://google.com => green lock 2. https://yahoo.com => white lock 3. https://just-skyline-137219.appspot.com/lightblue => opaque omnibox with green lock 4. https://garron.net/test/theme-color/?color=%2300ffff => transparent omnibox with dark lock In a CCT client app, set the toolbar color to the following colors and then visit https://www.google.com: 1. Default => green lock 2. #ef6c00 => white lock 3. #ffffcc => dark lock 4. #66ffff => dark lock Review-Url: https://codereview.chromium.org/2274973004 Cr-Commit-Position: refs/heads/master@{#414897} (cherry picked from commit cf4299907423c27d40182d17099d54a2e97e154c) Committed: https://chromium.googlesource.com/chromium/src/+/adc99c330347c25de4e310d7e8458a41cdcd656a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 2 chunks +13 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
estark
4 years, 3 months ago (2016-08-30 03:43:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
adc99c330347c25de4e310d7e8458a41cdcd656a.

Powered by Google App Engine
This is Rietveld 408576698