Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1664)

Unified Diff: scripts/slave/recipes/devtools.expected/devtools_fyi_no_devtools_file.json

Issue 2290923002: DevTools: Create recipe and builder for devtools (Closed)
Patch Set: add comments to devtools.py Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/devtools.expected/devtools_fyi_no_devtools_file.json
diff --git a/scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_mac_mac_upload_clang.json b/scripts/slave/recipes/devtools.expected/devtools_fyi_no_devtools_file.json
similarity index 94%
copy from scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_mac_mac_upload_clang.json
copy to scripts/slave/recipes/devtools.expected/devtools_fyi_no_devtools_file.json
index 2ccab1fee4ecc0153a061f435356f8d8e05875a7..c370a66a2c84b7b6ee1d6e7646dce3c2ecc66fd2 100644
--- a/scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_mac_mac_upload_clang.json
+++ b/scripts/slave/recipes/devtools.expected/devtools_fyi_no_devtools_file.json
@@ -5,9 +5,9 @@
"-u",
"RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",
"--master",
- "tryserver.chromium.mac",
+ "chromium.fyi",
"--builder",
- "mac_upload_clang",
+ "Chromium DevTools Linux",
"--slave",
"TestSlavename",
"--spec",
@@ -18,12 +18,6 @@
"{\"src\": \"got_revision\", \"src/buildtools\": \"got_buildtools_revision\", \"src/native_client\": \"got_nacl_revision\", \"src/third_party/angle\": \"got_angle_revision\", \"src/third_party/webrtc\": \"got_webrtc_revision\", \"src/tools/swarming_client\": \"got_swarming_client_revision\", \"src/v8\": \"got_v8_revision\"}",
"--git-cache-dir",
"[GIT_CACHE]",
- "--issue",
- "12853011",
- "--patchset",
- "1",
- "--rietveld_server",
- "https://codereview.chromium.org",
"--output_json",
"/path/to/tmp/json",
"--revision",
@@ -112,20 +106,25 @@
},
{
"cmd": [
- "python",
- "-u",
- "[SLAVE_BUILD]/src/third_party/binutils/download.py"
+ "git",
+ "diff",
+ "--cached",
+ "--name-only"
],
- "name": "download binutils"
+ "cwd": "[SLAVE_BUILD]/src",
+ "name": "git diff to analyze patch",
+ "stdout": "/path/to/tmp/",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@files@foo.cc@@@",
+ "@@@STEP_LOG_END@files@@@"
+ ]
},
{
"cmd": [
- "python",
- "-u",
- "[SLAVE_BUILD]/src/tools/clang/scripts/package.py",
- "--upload"
+ "echo",
+ "no devtools file in patch"
],
- "name": "package clang"
+ "name": "skip checks"
},
{
"name": "$result",
« no previous file with comments | « scripts/slave/recipes/devtools.py ('k') | scripts/slave/recipes/devtools.expected/devtools_fyi_with_devtools_file.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698