sdk/lib/_internal/compiler/implementation/scanner/listener.dart - Issue 22909056: Support general expressions as keys in literal maps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/scanner/listener.dart

Issue 22909056: Support general expressions as keys in literal maps. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart ('k') | sdk/lib/_internal/lib/constant_map.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/scanner/listener.dart

diff --git a/sdk/lib/_internal/compiler/implementation/scanner/listener.dart b/sdk/lib/_internal/compiler/implementation/scanner/listener.dart

index 1e8f36a4a958ff37f0a079ba6898acff20779727..dc912fb6dc637361375f5330459e94aaddb676c0 100644

--- a/sdk/lib/_internal/compiler/implementation/scanner/listener.dart

+++ b/sdk/lib/_internal/compiler/implementation/scanner/listener.dart

@@ -1622,9 +1622,6 @@ class NodeListener extends ElementListener {

void endLiteralMapEntry(Token colon, Token endToken) {

Expression value = popNode();

Expression key = popNode();

- if (key.asStringNode() == null) {

- recoverableError('expected a string', node: key);

- }

pushNode(new LiteralMapEntry(key, colon, value));

}