Support general expressions as keys in literal maps.

sdk/lib/_internal/compiler/implementation/constants.dart

Index: sdk/lib/_internal/compiler/implementation/constants.dart
diff --git a/sdk/lib/_internal/compiler/implementation/constants.dart b/sdk/lib/_internal/compiler/implementation/constants.dart
index 4ff011ccd77651823df56bc82d548abf3de51400..bca652405c49be6b45649dac303a38a077fdd068 100644
--- a/sdk/lib/_internal/compiler/implementation/constants.dart
+++ b/sdk/lib/_internal/compiler/implementation/constants.dart
@@ -374,19 +374,26 @@ class MapConstant extends ObjectConstant {
 
   /** The dart class implementing constant map literals. */
   static const SourceString DART_CLASS = const SourceString("ConstantMap");
+  static const SourceString DART_STRING_CLASS =
+      const SourceString("ConstantStringMap");
   static const SourceString DART_PROTO_CLASS =
       const SourceString("ConstantProtoMap");
+  static const SourceString DART_GENERAL_CLASS =
+      const SourceString("GeneralConstantMap");
   static const SourceString LENGTH_NAME = const SourceString("length");
   static const SourceString JS_OBJECT_NAME = const SourceString("_jsObject");
   static const SourceString KEYS_NAME = const SourceString("_keys");
   static const SourceString PROTO_VALUE = const SourceString("_protoValue");
+  static const SourceString JS_DATA_NAME = const SourceString("_jsData");
 
   final ListConstant keys;
   final List<Constant> values;
   final Constant protoValue;
   final int hashCode;
+  final bool onlyStringKeys;
 
-  MapConstant(DartType type, this.keys, List<Constant> values, this.protoValue)
+  MapConstant(DartType type, this.keys, List<Constant> values, this.protoValue,
+              this.onlyStringKeys)
       : this.values = values,
         this.hashCode = computeHash(type, values),
         super(type);
@@ -415,7 +422,14 @@ class MapConstant extends ObjectConstant {
   }
 
   List<Constant> getDependencies() {
-    List<Constant> result = <Constant>[keys];
+    List<Constant> result = <Constant>[];
+    if (onlyStringKeys) {
+      result.add(keys);
+    } else {
+      // Add the keys individually to avoid generating a unused list constant
+      // for the keys.

[ngeoffray, 2013/09/18 14:32:08]

I don't understand what is be the difference with onlyStringKeys then. It's fine
for onlyStringKeys to generate an unused list constant?

I though that keys would be the jsData.

[Johnni Winther, 2013/09/18 14:53:47]

For [:!onlyStringKeys:] jsData is the key-value pairs list generated in the
ConstantEmitter passed to [GeneralConstantMap]. In the case of [onlyStringKeys]
the [keys] list is provided as argument to [ConstantStringMap] in addition to
the key-value pairs list.

[ngeoffray, 2013/09/18 15:04:57]

OK, please add that as a comment.

+      result.addAll(keys.entries);
+    }
     result.addAll(values);
     return result;
   }