Trace memory records source function for posted tasks instead of "RunTask"

base/debug/trace_event.h

Index: base/debug/trace_event.h
diff --git a/base/debug/trace_event.h b/base/debug/trace_event.h
index 6805513b66aeb5a005e98937f97ea1580f398449..7257465b23bd27cfd7099ccaead61e4899a8e225 100644
--- a/base/debug/trace_event.h
+++ b/base/debug/trace_event.h
@@ -233,6 +233,14 @@
   INTERNAL_TRACE_EVENT_ADD_SCOPED( \
       category_group, name, arg1_name, arg1_val, arg2_name, arg2_val)
 
+// Records events like TRACE_EVENT2 but uses |arg2_val| for memory tracing.
+// Use this where |name| is too generic to accurately aggregate allocations.
+#define TRACE_EVENT2_MEMORY_ARG2( \
+    category_group, name, arg1_name, arg1_val, arg2_name, arg2_val) \
+  INTERNAL_TRACE_MEMORY(category_group, arg2_val) \
+  INTERNAL_TRACE_EVENT_ADD_SCOPED( \
+      category_group, name, arg1_name, arg1_val, arg2_name, arg2_val)

[dsinclair, 2013/08/23 13:39:47]

I like the use of a macro over doing it was done in the other CL, I really don't
like the macro name or it's magic grabbing of a given argument. What about
something like:

TRACE_EVENT_MEMORY_REALLOCATED2(
  "task",
  "MessageLoop::RunTask", 
  pending_task.posted_from.function_name(),
  "src_file", pending_task.posted_from.file_name(),
  "src_func", pending_task.posted_from.function_name());


Something like that? Is that worse, heh. I like having the explicit third
argument that is the thing you want to rename memory too, I think that's a lot
clearer then realizing arg2 value is going to be used.

+
 // UNSHIPPED_TRACE_EVENT* are like TRACE_EVENT* except that they are not
 // included in official builds.