third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp - Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp

Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>. (Closed)

Patch Set: Rebasing... Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.h ('k') | third_party/WebKit/Source/platform/image-decoders/SegmentReader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp b/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp

index f18d5f8c47cff12a1b0a7ecc3211108b8c784b77..bf2181ad0b54ffd13a4a0eab79cc25fc2b2e1731 100644

--- a/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp

@@ -54,7 +54,7 @@ PassRefPtr<SegmentReader> copyToROBufferSegmentReader(PassRefPtr<SegmentReader>

rwBuffer.append(segment, length);

position += length;

}

- return SegmentReader::createFromSkROBuffer(adoptRef(rwBuffer.newRBufferSnapshot()));

+ return SegmentReader::createFromSkROBuffer(sk_sp<SkROBuffer>(rwBuffer.newRBufferSnapshot()));

}

PassRefPtr<SegmentReader> copyToDataSegmentReader(PassRefPtr<SegmentReader> input)

@@ -216,7 +216,7 @@ TEST(SegmentReaderTest, variableSegments)

rwBuffer.append(referenceData + SharedBuffer::kSegmentSize, 2 * SharedBuffer::kSegmentSize);

rwBuffer.append(referenceData + 3 * SharedBuffer::kSegmentSize, .5 * SharedBuffer::kSegmentSize);

- segmentReader = SegmentReader::createFromSkROBuffer(adoptRef(rwBuffer.newRBufferSnapshot()));

+ segmentReader = SegmentReader::createFromSkROBuffer(sk_sp<SkROBuffer>(rwBuffer.newRBufferSnapshot()));

}

const char* segment;