third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp - Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>. (Closed)

Patch Set: Rebasing... Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h ('k') | third_party/WebKit/Source/platform/graphics/paint/PaintController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

index 06587565929ae14f0a1197e5f2eefeb5f8becacd..b8e2a0c0d111c7631154ce33869e8e4c253887e9 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

@@ -23,7 +23,7 @@ void DrawingDisplayItem::replay(GraphicsContext& context) const

void DrawingDisplayItem::appendToWebDisplayItemList(const IntRect& visualRect, WebDisplayItemList* list) const

{

if (m_picture)

- list->appendDrawingItem(visualRect, toSkSp(m_picture));

+ list->appendDrawingItem(visualRect, m_picture);

}

bool DrawingDisplayItem::drawsContent() const

@@ -60,8 +60,8 @@ static bool picturesEqual(const SkPicture* picture1, const SkPicture* picture2)

if (picture1Serialized.bytesWritten() != picture2Serialized.bytesWritten())

return false;

- RefPtr<SkData> data1 = adoptRef(picture1Serialized.copyToData());

- RefPtr<SkData> data2 = adoptRef(picture2Serialized.copyToData());

+ sk_sp<SkData> data1(picture1Serialized.copyToData());

+ sk_sp<SkData> data2(picture2Serialized.copyToData());

return data1->equals(data2.get());

}