third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp - Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp

Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>. (Closed)

Patch Set: Rebasing... Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp

index fe2c4b52c3b43ae2b0f0c4dbe551ed109765ea0f..3bb66bf6b2d76ef1bedf95011c65fb3846569753 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp

@@ -35,13 +35,13 @@ public:

FakeDisplayItemClient m_client;

};

-static PassRefPtr<SkPicture> createRectPicture(const IntRect& bounds)

+static sk_sp<SkPicture> createRectPicture(const IntRect& bounds)

{

SkPictureRecorder recorder;

SkCanvas* canvas = recorder.beginRecording(bounds.width(), bounds.height());

canvas->drawRect(SkRect::MakeXYWH(bounds.x(), bounds.y(), bounds.width(), bounds.height()),

SkPaint());

- return fromSkSp(recorder.finishRecordingAsPicture());

+ return recorder.finishRecordingAsPicture();

}

TEST_F(DisplayItemListTest, AppendVisualRect_Simple)