third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h - Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h

Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>. (Closed)

Patch Set: Rebasing... Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp ('k') | third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h

diff --git a/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h b/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h

index dc1163f82d1c2b3fdc94faa78e1642ea5da4eed3..ca8fd5709fa6cd72104bb9303e3d4dcac829aa3d 100644

--- a/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h

+++ b/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h

@@ -33,6 +33,7 @@

#include "platform/graphics/ImageBufferSurface.h"

#include "public/platform/WebGraphicsContext3DProvider.h"

+#include "third_party/skia/include/core/SkRefCnt.h"

#include "third_party/skia/include/core/SkSurface.h"

#include <memory>

@@ -47,7 +48,7 @@ public:

SkCanvas* canvas() override { return m_surface ? m_surface->getCanvas() : nullptr; }

bool isValid() const override { return m_surface; }

bool isAccelerated() const override { return true; }

- PassRefPtr<SkImage> newImageSnapshot(AccelerationHint, SnapshotReason) override;

+ sk_sp<SkImage> newImageSnapshot(AccelerationHint, SnapshotReason) override;

GLuint getBackingTextureHandleForOverwrite() override;

private: