third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp - Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>. (Closed)

Patch Set: Rebasing... Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp b/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

index da2801801e688735932b30b100799b3e59914b64..dc1ca86b1d2b6f8d36694b377efc9af6e2325c53 100644

--- a/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

+++ b/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

@@ -244,7 +244,7 @@ std::unique_ptr<JSONObject> objectForBitmapData(const SkBitmap& bitmap)

{

Vector<unsigned char> output;

- if (RefPtr<SkImage> image = fromSkSp(SkImage::MakeFromBitmap(bitmap))) {

+ if (sk_sp<SkImage> image = SkImage::MakeFromBitmap(bitmap)) {

ImagePixelLocker pixelLocker(image, kUnpremul_SkAlphaType, kRGBA_8888_SkColorType);

ImageDataBuffer imageData(IntSize(image->width(), image->height()),

static_cast<const unsigned char*>(pixelLocker.pixels()));