Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp

Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>. (Closed)
Patch Set: Rebasing... Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
index edbbe68e69f1baf1ffabe4243241bf19f13093ee..39ffe2505caadc568c382d0e9992e18bf6d79873 100644
--- a/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
+++ b/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
@@ -77,7 +77,7 @@ GraphicsContext::GraphicsContext(PaintController& paintController, DisabledMode
m_paintState = m_paintStateStack.last().get();
if (contextDisabled()) {
- DEFINE_STATIC_REF(SkCanvas, nullCanvas, (adoptRef(SkCreateNullCanvas())));
+ DEFINE_STATIC_LOCAL(SkCanvas*, nullCanvas, (SkCreateNullCanvas()));
m_canvas = nullCanvas;
}
}
@@ -236,7 +236,7 @@ void GraphicsContext::beginLayer(float opacity, SkXfermode::Mode xfermode, const
SkPaint layerPaint;
layerPaint.setAlpha(static_cast<unsigned char>(opacity * 255));
layerPaint.setXfermodeMode(xfermode);
- layerPaint.setColorFilter(toSkSp(WebCoreColorFilterToSkiaColorFilter(colorFilter)));
+ layerPaint.setColorFilter(WebCoreColorFilterToSkiaColorFilter(colorFilter));
layerPaint.setImageFilter(std::move(imageFilter));
if (bounds) {
@@ -273,28 +273,28 @@ void GraphicsContext::beginRecording(const FloatRect& bounds)
namespace {
-PassRefPtr<SkPicture> createEmptyPicture()
+sk_sp<SkPicture> createEmptyPicture()
{
SkPictureRecorder recorder;
recorder.beginRecording(SkRect::MakeEmpty(), nullptr);
- return fromSkSp(recorder.finishRecordingAsPicture());
+ return recorder.finishRecordingAsPicture();
}
} // anonymous namespace
-PassRefPtr<SkPicture> GraphicsContext::endRecording()
+sk_sp<SkPicture> GraphicsContext::endRecording()
{
if (contextDisabled()) {
// Clients expect endRecording() to always return a non-null picture.
// Cache an empty SKP to minimize overhead when disabled.
- DEFINE_STATIC_REF(SkPicture, emptyPicture, createEmptyPicture());
+ DEFINE_STATIC_LOCAL(sk_sp<SkPicture>, emptyPicture, (createEmptyPicture()));
return emptyPicture;
}
- RefPtr<SkPicture> picture = fromSkSp(m_pictureRecorder.finishRecordingAsPicture());
+ sk_sp<SkPicture> picture = m_pictureRecorder.finishRecordingAsPicture();
m_canvas = nullptr;
ASSERT(picture);
- return picture.release();
+ return picture;
}
void GraphicsContext::drawPicture(const SkPicture* picture)
@@ -306,7 +306,7 @@ void GraphicsContext::drawPicture(const SkPicture* picture)
m_canvas->drawPicture(picture);
}
-void GraphicsContext::compositePicture(PassRefPtr<SkPicture> picture, const FloatRect& dest, const FloatRect& src, SkXfermode::Mode op)
+void GraphicsContext::compositePicture(sk_sp<SkPicture> picture, const FloatRect& dest, const FloatRect& src, SkXfermode::Mode op)
{
if (contextDisabled() || !picture)
return;
@@ -320,7 +320,7 @@ void GraphicsContext::compositePicture(PassRefPtr<SkPicture> picture, const Floa
SkMatrix pictureTransform;
pictureTransform.setRectToRect(sourceBounds, skBounds, SkMatrix::kFill_ScaleToFit);
m_canvas->concat(pictureTransform);
- picturePaint.setImageFilter(SkPictureImageFilter::MakeForLocalSpace(toSkSp(picture), sourceBounds, static_cast<SkFilterQuality>(imageInterpolationQuality())));
+ picturePaint.setImageFilter(SkPictureImageFilter::MakeForLocalSpace(std::move(picture), sourceBounds, static_cast<SkFilterQuality>(imageInterpolationQuality())));
m_canvas->saveLayer(&sourceBounds, &picturePaint);
m_canvas->restore();
m_canvas->restore();
@@ -1226,11 +1226,11 @@ void GraphicsContext::adjustLineToPixelBoundaries(FloatPoint& p1, FloatPoint& p2
}
}
-PassRefPtr<SkColorFilter> GraphicsContext::WebCoreColorFilterToSkiaColorFilter(ColorFilter colorFilter)
+sk_sp<SkColorFilter> GraphicsContext::WebCoreColorFilterToSkiaColorFilter(ColorFilter colorFilter)
{
switch (colorFilter) {
case ColorFilterLuminanceToAlpha:
- return fromSkSp(SkLumaColorFilter::Make());
+ return SkLumaColorFilter::Make();
case ColorFilterLinearRGBToSRGB:
return ColorSpaceUtilities::createColorSpaceFilter(ColorSpaceLinearRGB, ColorSpaceDeviceRGB);
case ColorFilterSRGBToLinearRGB:

Powered by Google App Engine
This is Rietveld 408576698