Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Unified Diff: third_party/WebKit/Source/platform/graphics/BoxReflection.h

Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>. (Closed)
Patch Set: Rebasing... Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/BoxReflection.h
diff --git a/third_party/WebKit/Source/platform/graphics/BoxReflection.h b/third_party/WebKit/Source/platform/graphics/BoxReflection.h
index f22482fb633660c4ffd0e4d6f6743af571d3b841..41399624b05c8ce7889fa5c04903b994ce698d28 100644
--- a/third_party/WebKit/Source/platform/graphics/BoxReflection.h
+++ b/third_party/WebKit/Source/platform/graphics/BoxReflection.h
@@ -7,8 +7,7 @@
#include "platform/PlatformExport.h"
#include "third_party/skia/include/core/SkPicture.h"
-#include "wtf/PassRefPtr.h"
-#include "wtf/RefPtr.h"
+#include "third_party/skia/include/core/SkRefCnt.h"
class SkImageFilter;
class SkMatrix;
@@ -33,8 +32,8 @@ public:
HorizontalReflection,
};
- BoxReflection(ReflectionDirection direction, float offset, PassRefPtr<SkPicture> mask = nullptr)
- : m_direction(direction), m_offset(offset), m_mask(mask) {}
+ BoxReflection(ReflectionDirection direction, float offset, sk_sp<SkPicture> mask = nullptr)
+ : m_direction(direction), m_offset(offset), m_mask(std::move(mask)) {}
ReflectionDirection direction() const { return m_direction; }
float offset() const { return m_offset; }
@@ -54,7 +53,7 @@ public:
private:
ReflectionDirection m_direction;
float m_offset;
- RefPtr<SkPicture> m_mask;
+ sk_sp<SkPicture> m_mask;
};
inline bool operator==(const BoxReflection& a, const BoxReflection& b)

Powered by Google App Engine
This is Rietveld 408576698