Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>. (Closed)
Patch Set: Rebasing... Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
diff --git a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
index 839a8687eb16ad21f15f55e5e2aa61a5422d58a0..96b08881b9914554e5263eda267f112f451c59c1 100644
--- a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
+++ b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
@@ -118,9 +118,9 @@ ImageBitmap* OffscreenCanvasRenderingContext2D::transferToImageBitmap(ExceptionS
{
if (!imageBuffer())
return nullptr;
- RefPtr<SkImage> skImage = m_imageBuffer->newSkImageSnapshot(PreferAcceleration, SnapshotReasonTransferToImageBitmap);
+ sk_sp<SkImage> skImage = m_imageBuffer->newSkImageSnapshot(PreferAcceleration, SnapshotReasonTransferToImageBitmap);
DCHECK(isMainThread() || !skImage->isTextureBacked()); // Acceleration not yet supported in Workers
- RefPtr<StaticBitmapImage> image = StaticBitmapImage::create(skImage.release());
+ RefPtr<StaticBitmapImage> image = StaticBitmapImage::create(std::move(skImage));
image->setOriginClean(this->originClean());
m_imageBuffer.reset(); // "Transfer" means no retained buffer
m_needsMatrixClipRestore = true;
@@ -131,8 +131,8 @@ PassRefPtr<Image> OffscreenCanvasRenderingContext2D::getImage(SnapshotReason rea
{
if (!imageBuffer())
return nullptr;
- RefPtr<SkImage> skImage = m_imageBuffer->newSkImageSnapshot(PreferAcceleration, reason);
- RefPtr<StaticBitmapImage> image = StaticBitmapImage::create(skImage.release());
+ sk_sp<SkImage> skImage = m_imageBuffer->newSkImageSnapshot(PreferAcceleration, reason);
+ RefPtr<StaticBitmapImage> image = StaticBitmapImage::create(std::move(skImage));
return image;
}

Powered by Google App Engine
This is Rietveld 408576698