third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h - Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h

Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>. (Closed)

Patch Set: Rebasing... Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp ('k') | third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h

diff --git a/third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h b/third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h

index ebe280a79916359efd672ee336186cca3d92da04..7d2313e02c871d67093277b1a7e333b65555b236 100644

--- a/third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h

+++ b/third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h

@@ -8,6 +8,7 @@

#include "core/html/canvas/CanvasDrawListener.h"

#include "platform/heap/Handle.h"

#include "public/platform/WebCanvasCaptureHandler.h"

+#include "third_party/skia/include/core/SkRefCnt.h"

#include <memory>

namespace blink {

@@ -17,7 +18,7 @@ class OnRequestCanvasDrawListener final : public GarbageCollectedFinalized<OnReq

public:

~OnRequestCanvasDrawListener();

static OnRequestCanvasDrawListener* create(std::unique_ptr<WebCanvasCaptureHandler>);

- void sendNewFrame(WTF::PassRefPtr<SkImage>) override;

+ void sendNewFrame(sk_sp<SkImage>) override;

DEFINE_INLINE_TRACE() {}

private: