third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.cpp - Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.cpp

Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>. (Closed)

Patch Set: Self-review. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp ('K') | « third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.h ('k') | third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.h » ('j') | third_party/WebKit/Source/platform/image-decoders/SegmentReader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.cpp b/third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.cpp

index 70b051166858aab9099680f5b134da0c4d45fc92..4712a2170e8ec5b11b0d8a4315ee8613a66f1b22 100644

--- a/third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.cpp

+++ b/third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.cpp

@@ -24,7 +24,7 @@ bool infoIsCompatible(const SkImageInfo& info, SkAlphaType alphaType, SkColorTyp

} // anonymous namespace

-ImagePixelLocker::ImagePixelLocker(PassRefPtr<const SkImage> image, SkAlphaType alphaType,

+ImagePixelLocker::ImagePixelLocker(sk_sp<const SkImage> image, SkAlphaType alphaType,

SkColorType colorType)

: m_image(image)

f(malita) 2016/09/01 03:55:38 std::move(image)

Łukasz Anforowicz 2016/09/01 20:50:58 Done.

{