third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>. (Closed)

Patch Set: Self-review. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp ('K') | « third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp ('k') | third_party/WebKit/Source/platform/CrossThreadCopier.h » ('j') | third_party/WebKit/Source/platform/DragImage.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index 879e4578873d86e2ec4f81b696bd4746b73ce923..a32d2cfa05b18da5fee4e3d53ea26ca938fbfe69 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -4523,7 +4523,7 @@ void WebGLRenderingContextBase::texImageHelperImageBitmap(TexImageFunctionID fun

}

return;

}

- RefPtr<SkImage> skImage = bitmap->bitmapImage()->imageForCurrentFrame();

+ sk_sp<SkImage> skImage = bitmap->bitmapImage()->imageForCurrentFrame();

SkPixmap pixmap;

uint8_t* pixelDataPtr = nullptr;

RefPtr<Uint8Array> pixelData;