third_party/WebKit/Source/platform/fonts/TextBlob.h - Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/fonts/TextBlob.h

Issue 2290903002: Change (Pass)RefPtr<SkXxx> into sk_sp<SkXxx>. (Closed)

Patch Set: Self-review. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp ('K') | « third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp ('k') | third_party/WebKit/Source/platform/fonts/WebFontDecoder.h » ('j') | third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef TextBlob_h	5 #ifndef TextBlob_h

6 #define TextBlob_h	6 #define TextBlob_h

7	7

8 #include "third_party/skia/include/core/SkTextBlob.h"	8 #include "third_party/skia/include/core/SkTextBlob.h"

9 #include "wtf/PassRefPtr.h"

10 #include "wtf/RefPtr.h"

11	9

12 namespace blink {	10 namespace blink {

13	11

14 // Holds a (mutable) reference to an immutable SkTextBlob.	12 // Holds a (mutable) reference to an immutable SkTextBlob.

15 // Typedefs are used only to insulate core/ from Skia type names.	13 // Typedefs are used only to insulate core/ from Skia type names.

16 typedef RefPtr<const SkTextBlob> TextBlobPtr;	14 typedef sk_sp<const SkTextBlob> TextBlobPtr;

17 typedef PassRefPtr<const SkTextBlob> PassTextBlobPtr;	15 typedef sk_sp<const SkTextBlob> PassTextBlobPtr;
	f(malita) 2016/09/01 03:55:38 Heh, this is now painfully obsolete. Can you add Heh, this is now painfully obsolete. Can you add a TODO(fmalita) to get rid of it? Łukasz Anforowicz 2016/09/01 20:50:58 Done. Show quoted text On 2016/09/01 03:55:38, f(malita) wrote: > Heh, this is now painfully obsolete. Can you add a TODO(fmalita) to get rid of > it? Done.
18	16

19 } // namespace blink	17 } // namespace blink

20	18

21 #endif // TextBlob_h	19 #endif // TextBlob_h

OLD	NEW