Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22909017: Set chrome_multiple_dll=1 by default on Windows in static_library (Closed)

Created:
7 years, 4 months ago by scottmg
Modified:
7 years, 4 months ago
Reviewers:
jamesr, jam
CC:
chromium-reviews
Visibility:
Public.

Description

Set chrome_multiple_dll=1 by default on Windows in static_library TBR=jam@chromium.org R=jamesr@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218286

Patch Set 1 #

Patch Set 2 : content shouldn't depend on app_browser #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_android.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/content.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
scottmg
7 years, 4 months ago (2013-08-17 03:26:18 UTC) #1
jamesr
lgtm
7 years, 4 months ago (2013-08-17 04:58:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/22909017/19001
7 years, 4 months ago (2013-08-17 05:30:17 UTC) #3
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) media_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=78484
7 years, 4 months ago (2013-08-17 05:57:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/22909017/19001
7 years, 4 months ago (2013-08-17 16:15:54 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) media_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=78563
7 years, 4 months ago (2013-08-17 16:34:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/22909017/19001
7 years, 4 months ago (2013-08-18 07:05:58 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) media_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=78659
7 years, 4 months ago (2013-08-18 07:24:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/22909017/19001
7 years, 4 months ago (2013-08-19 15:12:26 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-19 15:15:17 UTC) #10
Message was sent while issue was closed. 
Change committed as 218286

Powered by Google App Engine
This is Rietveld 408576698