Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Unified Diff: content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Issue 22909011: Added support for GPU-based expectations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed device ids to use tuples Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/gpu/gpu_tests/webgl_conformance_expectations.py
diff --git a/content/test/gpu/gpu_tests/webgl_conformance_expectations.py b/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
index 05a68946b2a9765cbed63bff036b688e89684511..6f523f806b28caf762251d1702d1f4fed2b9d465 100644
--- a/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
+++ b/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
@@ -9,9 +9,13 @@ from telemetry.page import test_expectations
# mac leopard snowleopard lion mountainlion
# linux chromeos android
# nvidia amd intel
+# Specific gpu's can be listed as a tuple with vendor name and device ID.
+# Example: ('nvidia, 0x1234)
Ken Russell (switch to Gerrit) 2013/08/20 20:48:43 Missing close quote.
+# Device ID's must be paired with a gpu vendor.
class WebGLConformanceExpectations(test_expectations.TestExpectations):
def SetExpectations(self):
# Sample Usage:
- # self.Fail("gl-enable-vertex-attrib.html", ["mac", "win"], bug=1234)
+ # self.Fail("gl-enable-vertex-attrib.html",
+ # ['mac', 'amd', ('nvidia', 0x1234)], bug=123)
self.Fail('uniform-samplers-test.html', ['android'], bug=272080)

Powered by Google App Engine
This is Rietveld 408576698