Evaluate expression in context of an object

Evaluate expression in context of an object

This is the core functionality needed for the debugger. Integration
into the debugger wire protocol will follow in a separate change.

[hausner, 2013-08-14 23:54:09]

https://codereview.chromium.org/22909009/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/22909009/diff/1/runtime/vm/compiler.cc#newcod...
runtime/vm/compiler.cc:881: RawObject* Compiler::Evaluate(const Instance& obj,
const String& expr) {
Should this functionality be here in class Compiler or should it move somewhere
else?

[hausner, 2013-08-16 00:33:32]

CC'ing Devon

[Ivan Posva, 2013-08-19 21:32:18]

LGTM with comments.

-Ivan

https://codereview.chromium.org/22909009/diff/1/runtime/include/dart_debugger...
File runtime/include/dart_debugger_api.h (right):

https://codereview.chromium.org/22909009/diff/1/runtime/include/dart_debugger...
runtime/include/dart_debugger_api.h:484: DART_EXPORT Dart_Handle
Dart_EvaluateExpr(Dart_Handle object,
object -> target to match other functions in dart_api.h

https://codereview.chromium.org/22909009/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/22909009/diff/1/runtime/vm/compiler.cc#newcod...
runtime/vm/compiler.cc:881: RawObject* Compiler::Evaluate(const Instance& obj,
const String& expr) {
On 2013/08/14 23:54:09, hausner wrote:
> Should this functionality be here in class Compiler or should it move
somewhere
> else?

Could you add Evaluate on the Instance C++ class? Once we start supporting
evaluation in the context of a class or library then we could add Evaluate there
as well.

[hausner, 2013-08-19 22:47:38]

Thank you.

https://codereview.chromium.org/22909009/diff/1/runtime/include/dart_debugger...
File runtime/include/dart_debugger_api.h (right):

https://codereview.chromium.org/22909009/diff/1/runtime/include/dart_debugger...
runtime/include/dart_debugger_api.h:484: DART_EXPORT Dart_Handle
Dart_EvaluateExpr(Dart_Handle object,
On 2013/08/19 21:32:18, Ivan Posva wrote:
> object -> target to match other functions in dart_api.h

Done. Also added TODOs in the wire protocol code to add library and class
targets.

https://codereview.chromium.org/22909009/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/22909009/diff/1/runtime/vm/compiler.cc#newcod...
runtime/vm/compiler.cc:881: RawObject* Compiler::Evaluate(const Instance& obj,
const String& expr) {
On 2013/08/19 21:32:18, Ivan Posva wrote:
> On 2013/08/14 23:54:09, hausner wrote:
> > Should this functionality be here in class Compiler or should it move
> somewhere
> > else?
> 
> Could you add Evaluate on the Instance C++ class? Once we start supporting
> evaluation in the context of a class or library then we could add Evaluate
there
> as well.

Done.

[hausner, 2013-08-22 00:04:16]

This was committed with a different CL:

https://codereview.chromium.org/23067006/