Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2290893002: kernel -> ssa: support static invocations and variable gets (Closed)

Created:
4 years, 3 months ago by Harry Terkelsen
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

kernel -> ssa: support static invocations and variable gets R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/7b29f2b79c9d8bc36aab1e9418a9377ac5662382

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename typemask function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -22 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 6 chunks +46 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 1 chunk +38 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/kernel/helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/simple_function_test.dart View 1 chunk +18 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Harry Terkelsen
4 years, 3 months ago (2016-08-29 23:33:52 UTC) #2
Siggi Cherem (dart-lang)
lgtm, neat! https://codereview.chromium.org/2290893002/diff/1/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right): https://codereview.chromium.org/2290893002/diff/1/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart#newcode53 pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:53: TypeMask getTypeMask(ir.Node node) { nit: maybe rename ...
4 years, 3 months ago (2016-08-29 23:54:15 UTC) #3
Harry Terkelsen
thanks, siggi! https://codereview.chromium.org/2290893002/diff/1/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right): https://codereview.chromium.org/2290893002/diff/1/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart#newcode53 pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:53: TypeMask getTypeMask(ir.Node node) { On 2016/08/29 23:54:15, ...
4 years, 3 months ago (2016-08-30 00:05:41 UTC) #4
Harry Terkelsen
4 years, 3 months ago (2016-08-30 00:24:40 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
7b29f2b79c9d8bc36aab1e9418a9377ac5662382 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698