appengine/findit/waterfall/start_try_job_on_demand_pipeline.py - Issue 2290833002: [Findit] Fix a bug that MonitorTryJobPipeline still runs when no try job scheduled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/start_try_job_on_demand_pipeline.py

Issue 2290833002: [Findit] Fix a bug that MonitorTryJobPipeline still runs when no try job scheduled. (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/monitor_try_job_pipeline.py ('k') | appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/start_try_job_on_demand_pipeline.py

diff --git a/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py b/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py

index f08faf95ff56410835dfc8c0195385bf8f49c0d8..1388875b3a8dc7e3c579422dbd4f726fce0bc173 100644

--- a/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py

+++ b/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py

@@ -99,11 +99,11 @@ class StartTryJobOnDemandPipeline(BasePipeline):

try_job_id = yield ScheduleCompileTryJobPipeline(

master_name, builder_name, build_number, good_revision, bad_revision,

try_job_type, compile_targets, suspected_revisions)

- try_job_result = yield MonitorTryJobPipeline(

- master_name, builder_name, build_number, try_job_type, try_job_id)

- yield IdentifyTryJobCulpritPipeline(

- master_name, builder_name, build_number, blame_list, try_job_type,

- try_job_id, try_job_result)

+ # try_job_result = yield MonitorTryJobPipeline(

+ # master_name, builder_name, build_number, try_job_type, try_job_id)

+ # yield IdentifyTryJobCulpritPipeline(

+ # master_name, builder_name, build_number, blame_list, try_job_type,

+ # try_job_id, try_job_result)

Sharu Jiang 2016/08/29 20:53:20 Should these lines be removed?

stgao 2016/08/29 21:07:11 +1

chanli 2016/08/29 21:27:13 Oops, done.

else:

# If try_job_type is other type, the pipeline has returned.

# So here the try_job_type is failure_type.TEST.

@@ -122,8 +122,9 @@ class StartTryJobOnDemandPipeline(BasePipeline):

try_job_id = yield ScheduleTestTryJobPipeline(

master_name, builder_name, build_number, good_revision, bad_revision,

try_job_type, suspected_revisions, *reliable_tests)

- try_job_result = yield MonitorTryJobPipeline(

- master_name, builder_name, build_number, try_job_type, try_job_id)

- yield IdentifyTryJobCulpritPipeline(

- master_name, builder_name, build_number, blame_list, try_job_type,

- try_job_id, try_job_result)

+ try_job_result = yield MonitorTryJobPipeline(

+ master_name, builder_name, build_number, try_job_type, try_job_id)

+ yield IdentifyTryJobCulpritPipeline(

+ master_name, builder_name, build_number, blame_list, try_job_type,

+ try_job_id, try_job_result)