Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Unified Diff: content/browser/streams/stream_registry.h

Issue 22908008: Limit the total memory usage for Stream instances (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/streams/stream_registry.h
diff --git a/content/browser/streams/stream_registry.h b/content/browser/streams/stream_registry.h
index e75c97c1699ae1f625180b929bdc779c2696a619..32f452f65cf1f545dcabe7d7b26d71c810f524fe 100644
--- a/content/browser/streams/stream_registry.h
+++ b/content/browser/streams/stream_registry.h
@@ -32,20 +32,37 @@ class CONTENT_EXPORT StreamRegistry : public base::NonThreadSafe {
void UnregisterStream(const GURL& url);
+ // Called by Stream instances to request increase of memory usage. If the
+ // total memory usage for this registry is going to exceed the limit,
+ // subtracts |old_size| from |total_memory_usage_|, removes the stream from
+ // |streams_| and returns false.. Otherwise, updates
+ // |total_memory_usage_| and returns true.
+ bool CanIncreaseMemoryUsage(
+ const GURL& url, size_t last_size, size_t new_size);
+
// Gets the stream associated with |url|. Returns NULL if there is no such
// stream.
scoped_refptr<Stream> GetStream(const GURL& url);
+ // Only for testing.
+ void set_max_memory_usage(uint64 size) {
+ max_memory_usage_ = size;
+ }
+
private:
typedef std::map<GURL, scoped_refptr<Stream> > StreamMap;
StreamMap streams_;
+ size_t total_memory_usage_;
+
+ // Maximum amount of memory allowed to use for Stream instances registered
+ // with this registry.
+ uint64 max_memory_usage_;
kinuko 2013/08/14 09:32:23 Any reason you use different types for total and m
tyoshino (SeeGerritForStatus) 2013/08/15 04:15:33 Changed to use size_t
+
DISALLOW_COPY_AND_ASSIGN(StreamRegistry);
};
} // namespace content
#endif // CONTENT_BROWSER_STREAMS_STREAM_REGISTRY_H_
-
-

Powered by Google App Engine
This is Rietveld 408576698