Limit the total memory usage for Stream instances

content/browser/fileapi/fileapi_message_filter.cc

Index: content/browser/fileapi/fileapi_message_filter.cc
diff --git a/content/browser/fileapi/fileapi_message_filter.cc b/content/browser/fileapi/fileapi_message_filter.cc
index d5e903b3e9a2fad3ac4a1f4d6c4a4b004a2aaa8c..a0e6147088fbdc8c6cffdba85c077c9e9ddc946e 100644
--- a/content/browser/fileapi/fileapi_message_filter.cc
+++ b/content/browser/fileapi/fileapi_message_filter.cc
@@ -632,10 +632,8 @@ void FileAPIMessageFilter::OnAppendBlobDataItemToStream(
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   scoped_refptr<Stream> stream(GetStreamForURL(url));
-  if (!stream.get()) {
-    NOTREACHED();
+  if (!stream.get())

[kinuko, 2013/08/14 09:32:23]

This can happen now?

...oh I see, looks like yes.

[tyoshino (SeeGerritForStatus), 2013/08/15 04:15:33]

Yes. Needs to ignore failures now.

     return;
-  }
 
   // Data for stream is delivered as TYPE_BYTES item.
   if (item.type() != BlobData::Item::TYPE_BYTES) {
@@ -663,10 +661,8 @@ void FileAPIMessageFilter::OnAppendSharedMemoryToStream(
   }
 
   scoped_refptr<Stream> stream(GetStreamForURL(url));
-  if (!stream.get()) {
-    NOTREACHED();
+  if (!stream.get())
     return;
-  }
 
   stream->AddData(static_cast<char*>(shared_memory.memory()), buffer_size);
 }
@@ -676,17 +672,13 @@ void FileAPIMessageFilter::OnFinishBuildingStream(const GURL& url) {
   scoped_refptr<Stream> stream(GetStreamForURL(url));
   if (stream.get())
     stream->Finalize();
-  else
-    NOTREACHED();
 }
 
 void FileAPIMessageFilter::OnCloneStream(
     const GURL& url, const GURL& src_url) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-  if (!GetStreamForURL(src_url)) {
-    NOTREACHED();
+  if (!GetStreamForURL(src_url))
     return;
-  }
 
   stream_context_->registry()->CloneStream(url, src_url);
   stream_urls_.insert(url.spec());
@@ -695,10 +687,8 @@ void FileAPIMessageFilter::OnCloneStream(
 void FileAPIMessageFilter::OnRemoveStream(const GURL& url) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
-  if (!GetStreamForURL(url).get()) {
-    NOTREACHED();
+  if (!GetStreamForURL(url).get())
     return;
-  }
 
   stream_context_->registry()->UnregisterStream(url);
   stream_urls_.erase(url.spec());