Issue 22908005: Improve debug logging for GetNameFromProperties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22908005: Improve debug logging for GetNameFromProperties (Closed)

Created:
7 years, 4 months ago by stevenjb

Modified:
7 years, 4 months ago

Reviewers:
gauravsh

CC:
chromium-reviews, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Improve debug logging for GetNameFromProperties Better logging to help debug a problem with non-asci ssids. BUG=chrome-os-partner:18659 R=gauravsh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217132

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -9 lines)			Patch
M	chromeos/network/network_configuration_handler.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chromeos/network/network_state.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/network/network_state.cc	View	7 chunks	+11 lines, -6 lines	0 comments	Download
M	chromeos/network/shill_property_handler.cc	View	2 chunks	+0 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stevenjb

https://codereview.chromium.org/22908005/diff/1/chromeos/network/shill_property_handler.cc File chromeos/network/shill_property_handler.cc (left): https://codereview.chromium.org/22908005/diff/1/chromeos/network/shill_property_handler.cc#oldcode402 chromeos/network/shill_property_handler.cc:402: NET_LOG_DEBUG("StartObserving", path); Note: These were helpful initially but are ...

7 years, 4 months ago (2013-08-12 21:33:10 UTC) #1

stevenjb

7 years, 4 months ago (2013-08-13 00:25:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r217132 (presubmit successful).

Expand Messages | Collapse Messages