Updates the list of display info in TrayDisplay even if notification is prevented.

Updates the list of display info in TrayDisplay even if notification is prevented.

BUG=270200
R=oshima@chromium.org, stevenjb@chromium.org
TEST=new test case covers

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217143

[stevenjb, 2013-08-12 21:52:07]

lgtm w/ nits

https://codereview.chromium.org/22908004/diff/1/ash/system/chromeos/tray_disp...
File ash/system/chromeos/tray_display.cc (right):

https://codereview.chromium.org/22908004/diff/1/ash/system/chromeos/tray_disp...
ash/system/chromeos/tray_display.cc:342: }
Isn't this the same as:

if (old_info)
  old_info->swap(display_info_);
display_info_.clear();

? I think that would be more clear.

https://codereview.chromium.org/22908004/diff/1/ash/system/chromeos/tray_disp...
ash/system/chromeos/tray_display.cc:352: base::string16* message, const
TrayDisplay::DisplayInfoMap& old_info) {
one arg per line

https://codereview.chromium.org/22908004/diff/1/ash/system/chromeos/tray_disp...
File ash/system/chromeos/tray_display.h (right):

https://codereview.chromium.org/22908004/diff/1/ash/system/chromeos/tray_disp...
ash/system/chromeos/tray_display.h:49: base::string16* message, const
DisplayInfoMap& old_info);
one arg per line if not on the same line as the function name.

[Jun Mukai, 2013-08-12 22:07:48]

https://codereview.chromium.org/22908004/diff/1/ash/system/chromeos/tray_disp...
File ash/system/chromeos/tray_display.cc (right):

https://codereview.chromium.org/22908004/diff/1/ash/system/chromeos/tray_disp...
ash/system/chromeos/tray_display.cc:342: }
On 2013/08/12 21:52:07, stevenjb (chromium) wrote:
> Isn't this the same as:
> 
> if (old_info)
>   old_info->swap(display_info_);
> display_info_.clear();
> 
> ? I think that would be more clear.

good catch. fixed as you suggested.

https://codereview.chromium.org/22908004/diff/1/ash/system/chromeos/tray_disp...
ash/system/chromeos/tray_display.cc:352: base::string16* message, const
TrayDisplay::DisplayInfoMap& old_info) {
On 2013/08/12 21:52:07, stevenjb (chromium) wrote:
> one arg per line

Done.

https://codereview.chromium.org/22908004/diff/1/ash/system/chromeos/tray_disp...
File ash/system/chromeos/tray_display.h (right):

https://codereview.chromium.org/22908004/diff/1/ash/system/chromeos/tray_disp...
ash/system/chromeos/tray_display.h:49: base::string16* message, const
DisplayInfoMap& old_info);
On 2013/08/12 21:52:07, stevenjb (chromium) wrote:
> one arg per line if not on the same line as the function name.

Done.

[commit-bot: I haz the power, 2013-08-12 22:13:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/22908004/7001

[commit-bot: I haz the power, 2013-08-13 00:50:43]

Change committed as 217143