Sync up two accessibility enum files: ax_enums.idl and automation.idl

Sync up two accessibility enum files: ax_enums.idl and automation.idl

Add a PRESUBMIT rule that enforces that both ax_enums.idl and automation.idl
have matching enums so we don't accidentally let them get out of sync. Fix
one missing enum, and add a few missing enums directly to ChromeVox too.

BUG=641179
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/832058d16399740ae9db9dcc3699fb14e1de566c
Cr-Commit-Position: refs/heads/master@{#415768}

[dmazzoni, 2016-08-29 18:26:42]

Description was changed from

==========
Sync up two accessibility enum files: ax_enums.idl and automation.idl

Add a PRESUBMIT rule that enforces that both ax_enums.idl and automation.idl
have matching enums so we don't accidentally let them get out of sync. Fix
one missing enum, and add a few missing enums directly to ChromeVox too.

BUG=641179
==========

to

==========
Sync up two accessibility enum files: ax_enums.idl and automation.idl

Add a PRESUBMIT rule that enforces that both ax_enums.idl and automation.idl
have matching enums so we don't accidentally let them get out of sync. Fix
one missing enum, and add a few missing enums directly to ChromeVox too.

BUG=641179
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-08-29 18:26:59]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[dmazzoni, 2016-08-29 18:27:08]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 18:47:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:42:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:42:48]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-08-31 16:23:05]

Friendly ping

[David Tseng, 2016-08-31 19:39:29]

lgtm

https://codereview.chromium.org/2290763002/diff/1/ui/accessibility/PRESUBMIT.py
File ui/accessibility/PRESUBMIT.py (right):

https://codereview.chromium.org/2290763002/diff/1/ui/accessibility/PRESUBMIT....
ui/accessibility/PRESUBMIT.py:10: AUTOMATION_IDL =
'chrome/common/extensions/api/automation.idl'
Thanks for doing this. Can we check that anyone who touched automation.idl also
makes changes to
chrome/renderer/resources/extensions/automation/automation_node.js? (perhaps
just a warning).

[dmazzoni, 2016-08-31 19:51:43]

https://codereview.chromium.org/2290763002/diff/1/ui/accessibility/PRESUBMIT.py
File ui/accessibility/PRESUBMIT.py (right):

https://codereview.chromium.org/2290763002/diff/1/ui/accessibility/PRESUBMIT....
ui/accessibility/PRESUBMIT.py:10: AUTOMATION_IDL =
'chrome/common/extensions/api/automation.idl'
On 2016/08/31 at 19:39:29, David Tseng wrote:
> Thanks for doing this. Can we check that anyone who touched automation.idl
also makes changes to
chrome/renderer/resources/extensions/automation/automation_node.js? (perhaps
just a warning).

Sounds like that'd be a good follow-up. I don't want to warn
for any change to automation.idl because, for example, a change to
an enum requires a change to automation.idl but not to
automation_node.js

[dmazzoni, 2016-08-31 19:51:54]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-08-31 19:52:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2016-08-31 20:51:46]

https://codereview.chromium.org/2290763002/diff/1/ui/accessibility/PRESUBMIT.py
File ui/accessibility/PRESUBMIT.py (right):

https://codereview.chromium.org/2290763002/diff/1/ui/accessibility/PRESUBMIT....
ui/accessibility/PRESUBMIT.py:10: AUTOMATION_IDL =
'chrome/common/extensions/api/automation.idl'
On 2016/08/31 19:51:42, dmazzoni wrote:
> On 2016/08/31 at 19:39:29, David Tseng wrote:
> > Thanks for doing this. Can we check that anyone who touched automation.idl
> also makes changes to
> chrome/renderer/resources/extensions/automation/automation_node.js? (perhaps
> just a warning).
> 
> Sounds like that'd be a good follow-up. I don't want to warn
> for any change to automation.idl because, for example, a change to
> an enum requires a change to automation.idl but not to
> automation_node.js

How about just changes to ax_enums.idl?

 I mention it because a change to an enum could very well result in a change to
automation_node.js. Without it, the Automation API never installs the property
getter for an attribute since we keep a hard coded list of attributes there,
too. That list, is a subset of the one in the idl, but should just be
everything. For example, indirect children might be useful for ChromeVox table
navigation, but currently isn't listed in automation_node.js.

To be clear:
- automation.idl: used for documentation (published to Chrome Extension API
docs), also used for installing the bindings chrome.automation.[Event|Role]Type
- automation_node.js: lists the properties that get exposed on an instance of
automation node
- ax_enums.idl: the authorative list of enums
- chrome_extension_externs.js: used in Closure compilation upload presubmit
check

I think we need all four to be in sync or should think about combining them
eventually.

[dmazzoni, 2016-08-31 20:57:17]

> a change to an enum could very well result in a change to automation_node.js

Yes, changing one of the enums for int_attributes, string_attributes, etc. are
the ones that probably need such a change.

[commit-bot: I haz the power, 2016-08-31 21:55:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-31 21:57:16]

Description was changed from

==========
Sync up two accessibility enum files: ax_enums.idl and automation.idl

Add a PRESUBMIT rule that enforces that both ax_enums.idl and automation.idl
have matching enums so we don't accidentally let them get out of sync. Fix
one missing enum, and add a few missing enums directly to ChromeVox too.

BUG=641179
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Sync up two accessibility enum files: ax_enums.idl and automation.idl

Add a PRESUBMIT rule that enforces that both ax_enums.idl and automation.idl
have matching enums so we don't accidentally let them get out of sync. Fix
one missing enum, and add a few missing enums directly to ChromeVox too.

BUG=641179
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/832058d16399740ae9db9dcc3699fb14e1de566c
Cr-Commit-Position: refs/heads/master@{#415768}
==========

[commit-bot: I haz the power, 2016-08-31 21:57:17]

Patchset 1 (id:??) landed as
https://crrev.com/832058d16399740ae9db9dcc3699fb14e1de566c
Cr-Commit-Position: refs/heads/master@{#415768}