Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2290753002: Blink-compatible serialization of SharedArrayBuffer. (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Blink-compatible serialization of SharedArrayBuffer. BUG=chromium:148757 Committed: https://crrev.com/e2361954e53f60ea688553b6b8395f6580a60c9c Cr-Commit-Position: refs/heads/master@{#39017}

Patch Set 1 #

Patch Set 2 : SharedArrayBuffer cannot be copied #

Patch Set 3 : msvc dislikes array initializer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -6 lines) Patch
M include/v8.h View 2 chunks +13 lines, -0 lines 0 comments Download
M src/api.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/value-serializer.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/value-serializer.cc View 5 chunks +18 lines, -5 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 2 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
jbroman
4 years, 3 months ago (2016-08-29 18:54:04 UTC) #10
Jakob Kummerow
lgtm
4 years, 3 months ago (2016-08-30 12:25:47 UTC) #11
jbroman
+jochen for include/
4 years, 3 months ago (2016-08-30 12:36:46 UTC) #13
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-30 12:37:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290753002/40001
4 years, 3 months ago (2016-08-30 14:03:22 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-30 14:05:42 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 14:05:58 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e2361954e53f60ea688553b6b8395f6580a60c9c
Cr-Commit-Position: refs/heads/master@{#39017}

Powered by Google App Engine
This is Rietveld 408576698