third_party/WebKit/Source/core/frame/PRESUBMIT.py - Issue 2290733002: Add new UseCounter metric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/PRESUBMIT.py

Issue 2290733002: Add new UseCounter metric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make diff prettier Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/PRESUBMIT.py

diff --git a/third_party/WebKit/Source/core/frame/PRESUBMIT.py b/third_party/WebKit/Source/core/frame/PRESUBMIT.py

index 67c2ee8d78ee2c2a3b3eb6efafd59171cd2f0ae0..8eb93a3aae97bae6cb31bcd9d7b14766450ddadc 100644

--- a/third_party/WebKit/Source/core/frame/PRESUBMIT.py

+++ b/third_party/WebKit/Source/core/frame/PRESUBMIT.py

@@ -21,9 +21,9 @@ def _RunUseCounterChecks(input_api, output_api):

maximumBucket = 0

# Looking for a line like "case CSSPropertyGrid: return 453;"

bucketFinder = input_api.re.compile(r'.*CSSProperty.*return\s*([0-9]+).*')

- # Looking for a line like "static int maximumCSSSampleId() { return 452; }"

+ # Looking for a line like "int maximumCSSSampleId() { return 452; }"

maximumFinder = input_api.re.compile(

- r'static int maximumCSSSampleId\(\) { return ([0-9]+)')

+ r'int maximumCSSSampleId\(\) { return ([0-9]+)')

for line in useCounterCpp.NewContents():

bucketMatch = bucketFinder.match(line)

if bucketMatch: