Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1750)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2290733002: Add new UseCounter metric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Overhaul tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 9c5bb110dc67f1cbebe948d44a0d56454087c744..d9f727d092956d6cc8abe908c0f4530ba2e95d8a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -65820,12 +65820,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="WebCore.FeatureObserver" enum="FeatureObserver">
- <owner>dglazkov@chromium.org</owner>
+ <owner>rbyers@chromium.org</owner>
<summary>
- Count of how many instances of WebCore::Page use various features. Each
- WebCore::Page instance has a WebCore::UseCounter instance. It records and
- reports feature usage (e.g. via UseCounter::count() method). NOTE: dev
- numbers from 34.0.1800.1 to 34.0.1833.4 are wrong (see crbug.com/341631).
+ NOTE: This is in the process of being superceded by
dtapuska 2016/09/09 18:30:19 s/superceded/superseded ?
Rick Byers 2016/09/09 19:31:37 Done.
+ WebCore.UseCounter.Features which fixes a number of issues. See
+ https://crbug.com/597963.
+
+ Count of how many page loads use various features. The PageVisits bucket is
+ incremented for each page load, and the other buckets incremented at most
+ once per PageVisit via the WebCore::UseCounter class.
</summary>
</histogram>
@@ -65833,6 +65836,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
enum="MappedCSSProperties">
<owner>mikelawther@chromium.org</owner>
<summary>
+ NOTE: This is in the process of being superceded by
+ WebCore.UseCounter.CSSProperties which fixes a number of issues. See
+ https://crbug.com/597963.
+
Records usage of CSS properties used on a page, either statically or
dynamically, from the time the page is initialised to when it is closed or
navigated away from. Each property is counted at most once per page per
@@ -66404,6 +66411,53 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="WebCore.UseCounter.CSSProperties" enum="MappedCSSProperties">
+ <owner>rbyers@chromium.org</owner>
+ <summary>
+ NOTE: This is in the process of replacing
+ WebCore.FeatureObserver.CSSProperties which fixes a number of issues. See
+ https://crbug.com/597963.
+
+ Records usage of CSS properties used on a page, either statically or
+ dynamically, from the time the page is initialised to when it is closed or
+ navigated away from. Each property is counted at most once per page per
+ view.
+ </summary>
+ <details>
+ The first time a CSS property is parsed on a page, the histogram is updated
+ to increment the counter. Each histogram bucket corresponds to a CSS
+ property (eg. width, border-radius). The exception is the bucket numbered
+ '1' - this counts the number of pages that CSS properties were counted on.
+ When a page navigation occurs the page count bucket is incremented and
+ tracking of the set of which properties have been seen is reset.
+
+ These numbers give the percentage of pages that use a CSS property. For
+ example, if the 'border-radius' histogram bucket has a count of 250, and the
+ page count bucket (i.e. bucket number 1) has a count of 1000 - this means
+ that 1000 pages were recorded, and border-radius was used on 25% of those
+ pages.
+
+ TODO: The exact definition of &quot;page load&quot; is still
+ incorrect/fuzzy. https://crbug.com/236262
+ </details>
+</histogram>
+
+<histogram name="WebCore.UseCounter.Features" enum="FeatureObserver">
+ <owner>rbyers@chromium.org</owner>
+ <summary>
+ NOTE: This is in the process of replacing WebCore.FeatureObserver which
+ fixes a number of issues. See https://crbug.com/597963.
+
+ Count of how many page loads use various features. The PageVisits bucket is
+ incremented for each page load, and the other buckets incremented at most
+ once per PageVisit via the WebCore::UseCounter class.
+ </summary>
+ <details>
+ TODO: The exact definition of &quot;page load&quot; is still
+ incorrect/fuzzy. https://crbug.com/236262
+ </details>
+</histogram>
+
<histogram name="WebCore.V8DOMWindowShell.createContext.IsolatedWorld"
units="ms">
<obsolete>
@@ -79172,7 +79226,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<enum name="FeatureObserver" type="int">
<!-- Generated from third_party/WebKit/Source/core/frame/UseCounter.h -->
- <int value="0" label="PageDestruction"/>
+ <int value="0" label="OBSOLETE_PageDestruction"/>
<int value="1" label="LegacyNotifications"/>
<int value="2" label="MultipartMainResource"/>
<int value="3" label="PrefixedIndexedDB"/>

Powered by Google App Engine
This is Rietveld 408576698