Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2290703002: Make title text white in ash incognito popup window frames. (Closed)

Created:
4 years, 3 months ago by Daniel Erat
Modified:
4 years, 3 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make title text white in ash incognito popup window frames. In ash, incognito popup windows have dark-gray frames. Make their title text white rather than dark-gray so it can be read. BUG=640808 TEST=manual: both regular and incognito popup windows contain readable title text Committed: https://crrev.com/a5d40669ec06f3729b0c7099befda0f98f800863 Cr-Commit-Position: refs/heads/master@{#415098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/ui/views/frame/browser_header_painter_ash.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_header_painter_ash.cc View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Daniel Erat
(sky for approval)
4 years, 3 months ago (2016-08-29 16:53:07 UTC) #2
Evan Stade
lgtm
4 years, 3 months ago (2016-08-29 17:36:55 UTC) #5
Evan Stade
On 2016/08/29 17:36:55, Evan Stade (ooo wed-thurs) wrote: > lgtm I think you linked the ...
4 years, 3 months ago (2016-08-29 17:37:25 UTC) #6
Daniel Erat
On 2016/08/29 17:37:25, Evan Stade (ooo wed-thurs) wrote: > On 2016/08/29 17:36:55, Evan Stade (ooo ...
4 years, 3 months ago (2016-08-29 17:41:58 UTC) #8
sky
LGTM
4 years, 3 months ago (2016-08-29 17:52:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290703002/1
4 years, 3 months ago (2016-08-29 18:27:53 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 04:33:21 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:35:00 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5d40669ec06f3729b0c7099befda0f98f800863
Cr-Commit-Position: refs/heads/master@{#415098}

Powered by Google App Engine
This is Rietveld 408576698