Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2290633002: Fix document mode migration. (Closed)

Created:
4 years, 3 months ago by Peter Wen
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Fix document mode migration. There is an old tab_state file in the tabbed mode state directory. If it is not deleted and the new tab state is written to the new tab_state0 file, then when it comes time to run the migration code in TabPersistentStore the old tab_state file will be given preference and overwrite the new one with all the document mode tabs that were just migrated. Thus we need to delete the old tab_state file if it exists. BUG=640625 Review-Url: https://codereview.chromium.org/2274943002 Cr-Commit-Position: refs/heads/master@{#414194} (cherry picked from commit 9df9c7815b45e142c29162e02ddcdd8f411ec703) Committed: https://chromium.googlesource.com/chromium/src/+/07d0458654375ff59c8b592ddd86c667587de678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java View 2 chunks +10 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java View 10 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Peter Wen
4 years, 3 months ago (2016-08-29 13:22:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
07d0458654375ff59c8b592ddd86c667587de678.

Powered by Google App Engine
This is Rietveld 408576698