Trigger app banner when add to homescreen is pressed and WebAPKs are enabled.

chrome/browser/android/banners/app_banner_infobar_delegate_android.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_
 #define CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_
 
 #include "base/android/scoped_java_ref.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/banners/app_banner_manager.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
-#include "content/public/common/manifest.h"
 #include "ui/gfx/image/image.h"
 #include "url/gurl.h"
 
 namespace content {
 class WebContents;
 }
 
 namespace infobars {
 class InfoBarManager;
 }
 
 class AppBannerInfoBar;
+struct ShortcutInfo;
 
 namespace banners {
 
 // Manages installation of an app being promoted by a page.
 class AppBannerInfoBarDelegateAndroid : public ConfirmInfoBarDelegate {
  public:
-  // Delegate for promoting a web app.
-  AppBannerInfoBarDelegateAndroid(
+  // Creates and shows the infobar a web app.

[Peter Kasting, 2016/09/08 04:56:57]

Nit: Grammar.

Also, rather than "shows" I would be more specific, e.g. "Creates an infobar and
delegate for promoting the installation of a web app, and adds the infobar to
the InfoBarManager for |web_contents|."

[Xi Han, 2016/09/08 15:49:10]

Done.

+  static bool Create(
+      content::WebContents* web_contents,
       base::WeakPtr<AppBannerManager> weak_manager,
       const base::string16& app_title,
-      const GURL& manifest_url,
-      const content::Manifest& manifest,
-      const GURL& icon_url,
+      std::unique_ptr<ShortcutInfo> info,
       std::unique_ptr<SkBitmap> icon,
       int event_request_id,
-      bool is_webapk);
+      bool is_webapk,
+      bool start_install_webapk);
 
-  // Delegate for promoting an Android app.
-  AppBannerInfoBarDelegateAndroid(
+  // Creates and shows the infobar for an Android app.
+  static bool Create(
+      content::WebContents* web_contents,
       const base::string16& app_title,
       const base::android::ScopedJavaGlobalRef<jobject>& native_app_data,
       std::unique_ptr<SkBitmap> icon,
       const std::string& native_app_package,
       const std::string& referrer,
       int event_request_id);
 
   ~AppBannerInfoBarDelegateAndroid() override;
 
   // Called when the AppBannerInfoBar's button needs to be updated.
   void UpdateInstallState(JNIEnv* env,
                           const base::android::JavaParamRef<jobject>& obj);
 
   // Called when the installation Intent has been handled and focus has been
   // returned to Chrome.
   void OnInstallIntentReturned(JNIEnv* env,
                                const base::android::JavaParamRef<jobject>& obj,
                                jboolean jis_installing);
 
   // Called when the InstallerDelegate task has finished.
   void OnInstallFinished(JNIEnv* env,
                          const base::android::JavaParamRef<jobject>& obj,
                          jboolean success);
 
+  // Called in the following cases:
+  // - when user clicks the "Add To Homescreen" from the app menu to install a
+  //   WebAPK;
+  // - user accepts to install a WebAPK via the app banner;
+  // - user clicks the "open" button on the app banner after the WebAPK is
+  //   installed.

[Peter Kasting, 2016/09/08 04:56:57]

Rather than describing when this is called (which can get out of date as people
add or modify callsites, not updating this comment), just say what it actually
does, and what its return value means.

[Xi Han, 2016/09/08 15:49:10]

Done.

+  bool AcceptWebApk(content::WebContents* web_contents);
+
  private:
+  // Delegate for promoting a web app.
+  AppBannerInfoBarDelegateAndroid(
+      base::WeakPtr<AppBannerManager> weak_manager,
+      const base::string16& app_title,
+      std::unique_ptr<ShortcutInfo> info,
+      std::unique_ptr<SkBitmap> icon,
+      int event_request_id,
+      bool is_webapk);
+
+  // Delegate for promoting an Android app.
+  AppBannerInfoBarDelegateAndroid(
+      const base::string16& app_title,
+      const base::android::ScopedJavaGlobalRef<jobject>& native_app_data,
+      std::unique_ptr<SkBitmap> icon,
+      const std::string& native_app_package,
+      const std::string& referrer,
+      int event_request_id);
+
   void CreateJavaDelegate();
   bool AcceptNativeApp(content::WebContents* web_contents);
   bool AcceptWebApp(content::WebContents* web_contents);
-  bool AcceptWebApk(content::WebContents* web_contents);
   void SendBannerAccepted(content::WebContents* web_contents,
                           const std::string& platform);
   void OnWebApkInstallFinished(bool success, const std::string& webapk_package);
 
   // ConfirmInfoBarDelegate:
   infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;
   gfx::Image GetIcon() const override;
   void InfoBarDismissed() override;
   base::string16 GetMessageText() const override;
   int GetButtons() const override;
   bool Accept() override;
   bool LinkClicked(WindowOpenDisposition disposition) override;
 
   base::android::ScopedJavaGlobalRef<jobject> java_delegate_;
 
   // Used to fetch the splash screen icon for webapps.
   base::WeakPtr<AppBannerManager> weak_manager_;
 
   base::string16 app_title_;
-  GURL manifest_url_;
-  content::Manifest manifest_;
+  std::unique_ptr<ShortcutInfo> shortcut_info_;
 
   base::android::ScopedJavaGlobalRef<jobject> native_app_data_;
 
-  GURL icon_url_;
   std::unique_ptr<SkBitmap> icon_;
 
   std::string native_app_package_;
   std::string referrer_;
   int event_request_id_;
   bool has_user_interaction_;
 
   std::string webapk_package_name_;
   bool is_webapk_;
 
   base::WeakPtrFactory<AppBannerInfoBarDelegateAndroid> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AppBannerInfoBarDelegateAndroid);
-};  // AppBannerInfoBarDelegateAndroid
+};
 
 // Register native methods.
 bool RegisterAppBannerInfoBarDelegateAndroid(JNIEnv* env);
 
 }  // namespace banners
 
 #endif  // CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_