Trigger app banner when add to homescreen is pressed and WebAPKs are enabled.

chrome/browser/android/banners/app_banner_infobar_delegate_android.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_
 #define CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_
 
 #include "base/android/scoped_java_ref.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/banners/app_banner_manager.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
-#include "content/public/common/manifest.h"
 #include "ui/gfx/image/image.h"
 #include "url/gurl.h"
 
 namespace content {
 class WebContents;
 }
 
 namespace infobars {
 class InfoBarManager;
 }
 
 class AppBannerInfoBar;
+struct ShortcutInfo;
 
 namespace banners {
 
 // Manages installation of an app being promoted by a page.
 class AppBannerInfoBarDelegateAndroid : public ConfirmInfoBarDelegate {
  public:
   // Delegate for promoting a web app.
   AppBannerInfoBarDelegateAndroid(

[Peter Kasting, 2016/09/06 19:31:23]

Infobar delegate classes shouldn't have public constructors.  The constructor
should be private, and there should be a public Create() function that
constructs the delegate and its infobar and adds the infobar to the relevant
infobar service.  A simple such example is at
GeneratedPasswordSavedInfoBarDelegateAndroid::Create().

[Xi Han, 2016/09/07 15:53:17]

Done.

       base::WeakPtr<AppBannerManager> weak_manager,
       const base::string16& app_title,
-      const GURL& manifest_url,
-      const content::Manifest& manifest,
-      const GURL& icon_url,
+      std::unique_ptr<ShortcutInfo> info,

[Peter Kasting, 2016/09/06 19:31:23]

Why are you passing and storing this by unique_ptr instead of passing by const
ref and storing by value?  The lone caller of this constructor always passes a
non-null pointer, so this just obscures that.

[Xi Han, 2016/09/07 15:53:17]

Mostly because it is empty when the delegate is initialized for native app. In
|AppBannerInfoBarDelegateAndroid|, we could declare "ShortcutInfo shortcut_info"
or a unique_ptr. When initializing the delegate for native app, the
|shorcut_info| it is always empty since it is not used nor initialized. So I
could either introduce a default constructor for ShorcutInfo which doesn't have
one, or use unique_ptr for the empty case of native app. Personally I prefer to
use unique_ptr.

[Peter Kasting, 2016/09/08 04:56:56]

That makes sense for now.  It seems like this can change if the delegate is
split into pieces for the native versus web cases, so keep this change on the
list of things to consider doing then.

       std::unique_ptr<SkBitmap> icon,
       int event_request_id,
       bool is_webapk);
 
   // Delegate for promoting an Android app.
   AppBannerInfoBarDelegateAndroid(

[Peter Kasting, 2016/09/06 19:31:23]

Strongly consider splitting this infobar delegate into two different delegates. 
Right now there are two constructors that take very different parameter sets;
only some of the API methods are applicable to each type; only some of the
member variables are applicable to each type.  Maybe what you want is two
classes, possibly with a common base if they have shared functionality.

[Xi Han, 2016/09/07 15:53:17]

I agree, but I assume it is a big refactoring. It involves splitting logic on
InfobarDelegate and Infobar on both C++ and Java side. Since the changes don't
relate to this CL, I would prefer to do the refactoring in a follow up CL. 

[Peter Kasting, 2016/09/08 04:56:56]

I'm fine with that.

       const base::string16& app_title,
       const base::android::ScopedJavaGlobalRef<jobject>& native_app_data,
       std::unique_ptr<SkBitmap> icon,
       const std::string& native_app_package,
       const std::string& referrer,
       int event_request_id);
 
   ~AppBannerInfoBarDelegateAndroid() override;
 
   // Called when the AppBannerInfoBar's button needs to be updated.
   void UpdateInstallState(JNIEnv* env,
                           const base::android::JavaParamRef<jobject>& obj);
 
   // Called when the installation Intent has been handled and focus has been
   // returned to Chrome.
   void OnInstallIntentReturned(JNIEnv* env,
                                const base::android::JavaParamRef<jobject>& obj,
                                jboolean jis_installing);
 
   // Called when the InstallerDelegate task has finished.
   void OnInstallFinished(JNIEnv* env,
                          const base::android::JavaParamRef<jobject>& obj,
                          jboolean success);
 
+  // Called when user clicks the "Add To Homescreen" from the app menu to
+  // install a WebAPK. This function sets the text on infobar to "Adding" and
+  // disables the button to avoid user interaction. It also starts the WebAPK's
+  // installation process automatically.
+  void InstallWebApk(content::WebContents* web_contents);
+
  private:
   void CreateJavaDelegate();
   bool AcceptNativeApp(content::WebContents* web_contents);
   bool AcceptWebApp(content::WebContents* web_contents);
   bool AcceptWebApk(content::WebContents* web_contents);
   void SendBannerAccepted(content::WebContents* web_contents,
                           const std::string& platform);
   void OnWebApkInstallFinished(bool success, const std::string& webapk_package);
 
   // ConfirmInfoBarDelegate:
   infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;
   gfx::Image GetIcon() const override;
   void InfoBarDismissed() override;
   base::string16 GetMessageText() const override;
   int GetButtons() const override;
   bool Accept() override;
   bool LinkClicked(WindowOpenDisposition disposition) override;
+  AppBannerInfoBarDelegateAndroid* AsAppBannerInfoBarDelegateAndroid() override;
 
   base::android::ScopedJavaGlobalRef<jobject> java_delegate_;
 
   // Used to fetch the splash screen icon for webapps.
   base::WeakPtr<AppBannerManager> weak_manager_;
 
   base::string16 app_title_;
-  GURL manifest_url_;
-  content::Manifest manifest_;
+  std::unique_ptr<ShortcutInfo> shortcut_info_;
 
   base::android::ScopedJavaGlobalRef<jobject> native_app_data_;
 
-  GURL icon_url_;
   std::unique_ptr<SkBitmap> icon_;
 
   std::string native_app_package_;
   std::string referrer_;
   int event_request_id_;
   bool has_user_interaction_;
 
   std::string webapk_package_name_;
   bool is_webapk_;
 
   base::WeakPtrFactory<AppBannerInfoBarDelegateAndroid> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AppBannerInfoBarDelegateAndroid);
 };  // AppBannerInfoBarDelegateAndroid

[Peter Kasting, 2016/09/06 19:31:23]

Nit: We don't use trailing comments like this when closing classes.

[Xi Han, 2016/09/07 15:53:17]

Done.

 
 // Register native methods.
 bool RegisterAppBannerInfoBarDelegateAndroid(JNIEnv* env);
 
 }  // namespace banners
 
 #endif  // CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_