Trigger app banner when add to homescreen is pressed and WebAPKs are enabled.

chrome/browser/android/webapps/add_to_homescreen_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapps/add_to_homescreen_manager.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/guid.h"
 #include "base/location.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
 #include "chrome/browser/android/shortcut_helper.h"
 #include "chrome/browser/android/webapk/chrome_webapk_host.h"
 #include "chrome/browser/banners/app_banner_settings_helper.h"
+#include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/installable/installable_manager.h"
+#include "chrome/browser/ui/android/infobars/app_banner_infobar_android.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/origin_util.h"
 #include "jni/AddToHomescreenManager_jni.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/android/java_bitmap.h"
 
 using base::android::JavaParamRef;
 using base::android::ScopedJavaLocalRef;
 
@@ skipping 78 matching lines @@
 void AddToHomescreenManager::OnGotWebApkCompatibilityData(
     content::WebContents* web_contents,
     const InstallableData& installable_data) {
   OnDeterminedWebApkCompatibility(web_contents,
                                   installable_data.is_installable);
 }
 
 void AddToHomescreenManager::OnDeterminedWebApkCompatibility(
     content::WebContents* web_contents,
     bool is_compatible) {
-  // TODO(pkotwicz): Select whether to use dialog or not based on
-  // |is_compatible|.
-  ShowDialog();
+  is_compatible_ = is_compatible;
+  if (!is_compatible)
+    ShowDialog();
   StartFetchingInfoForShortcut(web_contents);
 }
 
 void AddToHomescreenManager::ShowDialog() {
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_AddToHomescreenManager_showDialog(env, java_ref_);
 }
 
 void AddToHomescreenManager::StartFetchingInfoForShortcut(
     content::WebContents* web_contents) {
@@ skipping 32 matching lines @@
 
   AppBannerSettingsHelper::RecordBannerEvent(
       web_contents, web_contents->GetURL(),
       data_fetcher_->shortcut_info().url.spec(),
       AppBannerSettingsHelper::APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN,
       base::Time::Now());
 }
 
 void AddToHomescreenManager::OnUserTitleAvailable(
     const base::string16& user_title) {
+  if (is_compatible_)
+    return;
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jstring> j_user_title =
       base::android::ConvertUTF16ToJavaString(env, user_title);
   Java_AddToHomescreenManager_onUserTitleAvailable(env,
                                                    java_ref_,
                                                    j_user_title);
 }
 
 void AddToHomescreenManager::OnDataAvailable(const ShortcutInfo& info,
                                              const SkBitmap& icon) {
+  if (is_compatible_) {
+    CreateInfobar(info, icon);
+    return;
+  }
+
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> java_bitmap;
   if (icon.getSize())
     java_bitmap = gfx::ConvertToJavaBitmap(&icon);
 
   Java_AddToHomescreenManager_onReadyToAdd(env, java_ref_, java_bitmap);
 
   if (add_shortcut_pending_)
     AddShortcut(info, icon);
 }
 
+void AddToHomescreenManager::CreateInfobar(const ShortcutInfo& info,
+                                           const SkBitmap& icon) {
+  std::unique_ptr<ShortcutInfo> info_ptr(new ShortcutInfo(info));
+  std::unique_ptr<SkBitmap> icon_ptr(new SkBitmap(icon));
+  std::unique_ptr<banners::AppBannerInfoBarDelegateAndroid> delegate(
+      new banners::AppBannerInfoBarDelegateAndroid(
+          nullptr, info.user_title, info.manifest_url, std::move(info_ptr),
+          info.icon_url, std::move(icon_ptr), -1 /* event_request_id */,
+          true));
+
+  infobars::InfoBar* infobar = new AppBannerInfoBarAndroid(
+      std::move(delegate), data_fetcher_->shortcut_info().url, true);
+  if (infobar) {

[gone, 2016/08/31 18:12:45]

if (!infobar)
  return;

saves you a level of indentation.

[Xi Han, 2016/08/31 20:11:48]

I will be more careful and use early exist as much as possible.

+    content::WebContents* web_contents = data_fetcher_->web_contents();
+    if (!web_contents) {
+      LOG(ERROR) << "Failed to create infobar to install the WebAPK: "
+                 << "the associated WebContents is null.";
+      return;
+    }
+    InfoBarService::FromWebContents(web_contents)->AddInfoBar(
+        base::WrapUnique(infobar));
+    static_cast<AppBannerInfoBarAndroid*>(infobar)->InstallWebApk(web_contents);
+  }
+}
+
 SkBitmap AddToHomescreenManager::FinalizeLauncherIconInBackground(
     const SkBitmap& bitmap,
     const GURL& url,
     bool* is_generated) {
   DCHECK(content::BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
 
   return ShortcutHelper::FinalizeLauncherIconInBackground(bitmap, url,
                                                           is_generated);
 }