Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: ash/common/shelf/shelf_delegate.h

Issue 2290603002: Enhance chrome.app.window API for shelf integration with pinning support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review v4 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/mus/shell_delegate_mus.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/shelf_delegate.h
diff --git a/ash/common/shelf/shelf_delegate.h b/ash/common/shelf/shelf_delegate.h
index fa5e0b9cc66d2e373a82005967214fb94ec4330d..fc72c64cb4581bda85c11fc40d458b22536b40b2 100644
--- a/ash/common/shelf/shelf_delegate.h
+++ b/ash/common/shelf/shelf_delegate.h
@@ -42,6 +42,14 @@ class ASH_EXPORT ShelfDelegate {
// Get the shelf ID from an application ID.
virtual ShelfID GetShelfIDForAppID(const std::string& app_id) = 0;
+ // Get the shelf ID from an application ID and a launch ID.
+ // The launch ID can be passed to an app when launched in order to support
+ // multiple shelf items per app. This id is used together with the app_id to
+ // uniquely identify each shelf item that has the same app_id.
James Cook 2016/09/01 16:15:18 nit: I would also say something like: "For example
Andra Paraschiv 2016/09/02 07:35:44 Done.
+ virtual ShelfID GetShelfIDForAppIDAndLaunchID(
+ const std::string& app_id,
+ const std::string& launch_id) = 0;
+
// Checks whether a mapping exists from the ShelfID |id| to an app id.
virtual bool HasShelfIDToAppIDMapping(ShelfID id) const = 0;
« no previous file with comments | « no previous file | ash/mus/shell_delegate_mus.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698