Enhance chrome.app.window API for shelf integration with pinning support

chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h

Index: chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h
diff --git a/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h b/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h
index 28d976ceddcf091e239beb4736390fc769596828..6476963495f400433e9b00ba4edca4441ac4eec6 100644
--- a/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h
+++ b/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h
@@ -42,7 +42,8 @@ class AppWindowLauncherItemController : public LauncherItemController,
   void SetActiveWindow(aura::Window* window);
   ui::BaseWindow* GetAppWindow(aura::Window* window);
 
-  const std::string& app_shelf_id() const { return app_shelf_id_; }
+  const std::string& app_id() const { return app_id_; }
+  const std::string& launch_id() const { return launch_id_; }
 
   // LauncherItemController overrides:
   bool IsOpen() const override;
@@ -74,7 +75,7 @@ class AppWindowLauncherItemController : public LauncherItemController,
 
  protected:
   AppWindowLauncherItemController(Type type,
-                                  const std::string& app_shelf_id,
+                                  const std::string& launch_id,
                                   const std::string& app_id,

[stevenjb, 2016/08/30 16:12:51]

Yikes. Please change this to app_id, launch_id so that the order is consistent
with everything else.

[Andra Paraschiv, 2016/08/31 10:57:18]

Done.

                                   ChromeLauncherController* controller);
 
@@ -102,9 +103,13 @@ class AppWindowLauncherItemController : public LauncherItemController,
   // Pointer to the most recently active app window
   ui::BaseWindow* last_active_window_ = nullptr;
 
+  // The application id associated with this set of windows.
+  const std::string app_id_;
+
   // The launcher id associated with this set of windows. There is one
-  // AppLauncherItemController for each |app_shelf_id_|.
-  const std::string app_shelf_id_;
+  // AppLauncherItemController for each app_shelf_id whose value is
+  // |launch_id_| appended to |app_id_|.
+  const std::string launch_id_;
 
   // Scoped list of observed windows (for removal on destruction)
   ScopedObserver<aura::Window, aura::WindowObserver> observed_windows_;