chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc - Issue 2290603002: Enhance chrome.app.window API for shelf integration with pinning support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc

Issue 2290603002: Enhance chrome.app.window API for shelf integration with pinning support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: LauncherItemController Unit Tests Fix after Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.h ('k') | chrome/browser/ui/ash/launcher/launcher_item_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc

diff --git a/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc b/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc

index eec6416a8cf6166a8f187f362b551eba9a4a2745..cac6a1b1b7423e2d460cbfdcc93f3d897f5b3fd8 100644

--- a/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc

+++ b/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc

@@ -51,10 +51,10 @@ gfx::Image GetAppListIcon(extensions::AppWindow* app_window) {

ExtensionAppWindowLauncherItemController::

ExtensionAppWindowLauncherItemController(

Type type,

- const std::string& app_shelf_id,

const std::string& app_id,

+ const std::string& launch_id,

ChromeLauncherController* controller)

- : AppWindowLauncherItemController(type, app_shelf_id, app_id, controller) {}

+ : AppWindowLauncherItemController(type, app_id, launch_id, controller) {}

ExtensionAppWindowLauncherItemController::

~ExtensionAppWindowLauncherItemController() {}