chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h - Issue 2290603002: Enhance chrome.app.window API for shelf integration with pinning support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

Issue 2290603002: Enhance chrome.app.window API for shelf integration with pinning support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: LauncherItemController Unit Tests Fix after Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

index cf4550f196d434426f38718b74195538a200ef45..2561fd4a64ad2fa0e1ba38055caa9d699654e72d 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

@@ -157,6 +157,9 @@ class ChromeLauncherControllerImpl

void OnShelfAutoHideStateChanged(ash::WmShelf* shelf) override;

void OnShelfVisibilityStateChanged(ash::WmShelf* shelf) override;

ash::ShelfID GetShelfIDForAppID(const std::string& app_id) override;

+ ash::ShelfID GetShelfIDForAppIDAndLaunchID(

+ const std::string& app_id,

+ const std::string& launch_id) override;

bool HasShelfIDToAppIDMapping(ash::ShelfID id) const override;

const std::string& GetAppIDForShelfID(ash::ShelfID id) override;

void PinAppWithID(const std::string& app_id) override;