chrome/browser/ui/ash/app_list/app_list_controller_ash.cc - Issue 2290603002: Enhance chrome.app.window API for shelf integration with pinning support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

Issue 2290603002: Enhance chrome.app.window API for shelf integration with pinning support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/test/test_shelf_delegate.cc ('K') | « ash/test/test_shelf_delegate.cc ('k') | chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h » ('j') | chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

diff --git a/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc b/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

index b348d1a27437e8b83f53aedc641fd8e6741518ca..3e5114867fe81b5f8205225c611e63255559dc75 100644

--- a/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

+++ b/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

@@ -45,7 +45,7 @@ bool AppListControllerDelegateAsh::IsAppPinned(const std::string& app_id) {

bool AppListControllerDelegateAsh::IsAppOpen(const std::string& app_id) const {

ash::ShelfID id =

- ash::WmShell::Get()->shelf_delegate()->GetShelfIDForAppID(app_id);

+ ash::WmShell::Get()->shelf_delegate()->GetShelfIDForAppID(app_id, app_id);

return id && ChromeLauncherController::instance()->IsOpen(id);

}