Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1965)

Unified Diff: ash/common/shelf/shelf_delegate.h

Issue 2290603002: Enhance chrome.app.window API for shelf integration with pinning support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/common/shelf/shelf_view.cc » ('j') | ash/common/shelf/shelf_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/shelf_delegate.h
diff --git a/ash/common/shelf/shelf_delegate.h b/ash/common/shelf/shelf_delegate.h
index 7c58121d3fa110714ee4607591e3da7e5af5403f..94ca69c75a9eb726d8205f0cad8869c357a88b18 100644
--- a/ash/common/shelf/shelf_delegate.h
+++ b/ash/common/shelf/shelf_delegate.h
@@ -37,7 +37,8 @@ class ASH_EXPORT ShelfDelegate {
virtual void OnShelfVisibilityStateChanged(Shelf* shelf) = 0;
// Get the shelf ID from an application ID.
stevenjb 2016/08/29 15:56:30 The comment needs to be updated, but this is kind
Andra Paraschiv 2016/08/30 09:58:24 Added a separate delegate method that includes the
- virtual ShelfID GetShelfIDForAppID(const std::string& app_id) = 0;
+ virtual ShelfID GetShelfIDForAppID(const std::string& app_id,
+ const std::string& app_shelf_id) = 0;
// Checks whether a mapping exists from the ShelfID |id| to an app id.
virtual bool HasShelfIDToAppIDMapping(ShelfID id) const = 0;
« no previous file with comments | « no previous file | ash/common/shelf/shelf_view.cc » ('j') | ash/common/shelf/shelf_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698