Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7460)

Unified Diff: Source/modules/imagebitmap/ImageBitmapFactories.cpp

Issue 22906002: Implement ImageBitmapFactories as a supplementary module. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Keep IDL implements statement. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/imagebitmap/ImageBitmapFactories.cpp
diff --git a/Source/core/page/ImageBitmapFactories.cpp b/Source/modules/imagebitmap/ImageBitmapFactories.cpp
similarity index 74%
rename from Source/core/page/ImageBitmapFactories.cpp
rename to Source/modules/imagebitmap/ImageBitmapFactories.cpp
index a68e94e4eaedd65bb2baeb622569962f80743264..45857bfc23255f3ee5559552c290fd6419bd5049 100644
--- a/Source/core/page/ImageBitmapFactories.cpp
+++ b/Source/modules/imagebitmap/ImageBitmapFactories.cpp
@@ -29,7 +29,7 @@
*/
#include "config.h"
-#include "core/page/ImageBitmapFactories.h"
+#include "modules/imagebitmap/ImageBitmapFactories.h"
do-not-use 2013/08/12 18:43:59 Someone needs to comment about the move to modules
#include "RuntimeEnabledFeatures.h"
#include "V8ImageBitmap.h"
@@ -45,7 +45,10 @@
namespace WebCore {
-namespace ImageBitmapFactories {
+ImageBitmapFactories::ImageBitmapFactories(DOMWindow* window)
do-not-use 2013/08/12 18:43:59 If we stop subclassing DOMWindowProperty then we n
+ : DOMWindowProperty(window->frame())
+{
+}
static LayoutSize sizeFor(HTMLImageElement* image)
{
@@ -71,13 +74,13 @@ static ScriptObject resolveImageBitmap(PassRefPtr<ImageBitmap> imageBitmap)
return resolver->promise();
}
-ScriptObject createImageBitmap(EventTarget* eventTarget, HTMLImageElement* image, ExceptionState& es)
+ScriptObject ImageBitmapFactories::createImageBitmap(EventTarget* eventTarget, HTMLImageElement* image, ExceptionState& es)
{
LayoutSize s = sizeFor(image);
return createImageBitmap(eventTarget, image, 0, 0, s.width(), s.height(), es);
}
-ScriptObject createImageBitmap(EventTarget* eventTarget, HTMLImageElement* image, int sx, int sy, int sw, int sh, ExceptionState& es)
+ScriptObject ImageBitmapFactories::createImageBitmap(EventTarget* eventTarget, HTMLImageElement* image, int sx, int sy, int sw, int sh, ExceptionState& es)
{
if (!image) {
es.throwTypeError();
@@ -108,13 +111,13 @@ ScriptObject createImageBitmap(EventTarget* eventTarget, HTMLImageElement* image
return resolveImageBitmap(ImageBitmap::create(image, IntRect(sx, sy, sw, sh)));
}
-ScriptObject createImageBitmap(EventTarget* eventTarget, HTMLVideoElement* video, ExceptionState& es)
+ScriptObject ImageBitmapFactories::createImageBitmap(EventTarget* eventTarget, HTMLVideoElement* video, ExceptionState& es)
{
IntSize s = sizeFor(video);
return createImageBitmap(eventTarget, video, 0, 0, s.width(), s.height(), es);
}
-ScriptObject createImageBitmap(EventTarget* eventTarget, HTMLVideoElement* video, int sx, int sy, int sw, int sh, ExceptionState& es)
+ScriptObject ImageBitmapFactories::createImageBitmap(EventTarget* eventTarget, HTMLVideoElement* video, int sx, int sy, int sw, int sh, ExceptionState& es)
{
if (!video) {
es.throwTypeError();
@@ -148,22 +151,22 @@ ScriptObject createImageBitmap(EventTarget* eventTarget, HTMLVideoElement* video
return resolveImageBitmap(ImageBitmap::create(video, IntRect(sx, sy, sw, sh)));
}
-ScriptObject createImageBitmap(EventTarget* eventTarget, CanvasRenderingContext2D* context, ExceptionState& es)
+ScriptObject ImageBitmapFactories::createImageBitmap(EventTarget* eventTarget, CanvasRenderingContext2D* context, ExceptionState& es)
{
return createImageBitmap(eventTarget, context->canvas(), es);
}
-ScriptObject createImageBitmap(EventTarget* eventTarget, CanvasRenderingContext2D* context, int sx, int sy, int sw, int sh, ExceptionState& es)
+ScriptObject ImageBitmapFactories::createImageBitmap(EventTarget* eventTarget, CanvasRenderingContext2D* context, int sx, int sy, int sw, int sh, ExceptionState& es)
{
return createImageBitmap(eventTarget, context->canvas(), sx, sy, sw, sh, es);
}
-ScriptObject createImageBitmap(EventTarget* eventTarget, HTMLCanvasElement* canvas, ExceptionState& es)
+ScriptObject ImageBitmapFactories::createImageBitmap(EventTarget* eventTarget, HTMLCanvasElement* canvas, ExceptionState& es)
{
return createImageBitmap(eventTarget, canvas, 0, 0, canvas->width(), canvas->height(), es);
}
-ScriptObject createImageBitmap(EventTarget* eventTarget, HTMLCanvasElement* canvas, int sx, int sy, int sw, int sh, ExceptionState& es)
+ScriptObject ImageBitmapFactories::createImageBitmap(EventTarget* eventTarget, HTMLCanvasElement* canvas, int sx, int sy, int sw, int sh, ExceptionState& es)
{
if (!canvas) {
es.throwTypeError();
@@ -181,12 +184,12 @@ ScriptObject createImageBitmap(EventTarget* eventTarget, HTMLCanvasElement* canv
return resolveImageBitmap(ImageBitmap::create(canvas, IntRect(sx, sy, sw, sh)));
}
-ScriptObject createImageBitmap(EventTarget* eventTarget, ImageData* data, ExceptionState& es)
+ScriptObject ImageBitmapFactories::createImageBitmap(EventTarget* eventTarget, ImageData* data, ExceptionState& es)
{
return createImageBitmap(eventTarget, data, 0, 0, data->width(), data->height(), es);
}
-ScriptObject createImageBitmap(EventTarget* eventTarget, ImageData* data, int sx, int sy, int sw, int sh, ExceptionState& es)
+ScriptObject ImageBitmapFactories::createImageBitmap(EventTarget* eventTarget, ImageData* data, int sx, int sy, int sw, int sh, ExceptionState& es)
{
if (!data) {
es.throwTypeError();
@@ -200,12 +203,12 @@ ScriptObject createImageBitmap(EventTarget* eventTarget, ImageData* data, int sx
return resolveImageBitmap(ImageBitmap::create(data, IntRect(sx, sy, sw, sh)));
}
-ScriptObject createImageBitmap(EventTarget* eventTarget, ImageBitmap* bitmap, ExceptionState& es)
+ScriptObject ImageBitmapFactories::createImageBitmap(EventTarget* eventTarget, ImageBitmap* bitmap, ExceptionState& es)
{
return createImageBitmap(eventTarget, bitmap, 0, 0, bitmap->width(), bitmap->height(), es);
}
-ScriptObject createImageBitmap(EventTarget* eventTarget, ImageBitmap* bitmap, int sx, int sy, int sw, int sh, ExceptionState& es)
+ScriptObject ImageBitmapFactories::createImageBitmap(EventTarget* eventTarget, ImageBitmap* bitmap, int sx, int sy, int sw, int sh, ExceptionState& es)
{
if (!bitmap) {
es.throwTypeError();
@@ -219,5 +222,19 @@ ScriptObject createImageBitmap(EventTarget* eventTarget, ImageBitmap* bitmap, in
return resolveImageBitmap(ImageBitmap::create(bitmap, IntRect(sx, sy, sw, sh)));
}
-} // namespace ImageBitmapFactories
+const char* ImageBitmapFactories::supplementName()
+{
+ return "ImageBitmapFactories";
+}
+
+ImageBitmapFactories* ImageBitmapFactories::from(DOMWindow* window)
+{
+ ImageBitmapFactories* supplement = static_cast<ImageBitmapFactories*>(Supplement<DOMWindow>::from(window, supplementName()));
+ if (!supplement) {
+ supplement = new ImageBitmapFactories(window);
+ provideTo(window, supplementName(), adoptPtr(supplement));
+ }
+ return supplement;
+}
+
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698