Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2290583002: [turbofan] Remove dead opcode handlers from simplified lowering. (Closed)

Created:
4 years, 3 months ago by Jarin
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove dead opcode handlers from simplified lowering. Committed: https://crrev.com/86c5c52e36ea3fbd4ab00b425f2a16c192d89079 Cr-Commit-Position: refs/heads/master@{#38988}

Patch Set 1 #

Patch Set 2 : Use macros #

Patch Set 3 : White list #

Patch Set 4 : Tweak #

Patch Set 5 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -188 lines) Patch
M src/compiler/simplified-lowering.cc View 1 2 3 4 6 chunks +42 lines, -188 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
Jarin
Could you take a look, please?
4 years, 3 months ago (2016-08-29 11:39:53 UTC) #14
Benedikt Meurer
Awesome! LGTM, thanks.
4 years, 3 months ago (2016-08-29 16:40:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290583002/80001
4 years, 3 months ago (2016-08-29 19:18:08 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-29 19:40:20 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 19:41:14 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/86c5c52e36ea3fbd4ab00b425f2a16c192d89079
Cr-Commit-Position: refs/heads/master@{#38988}

Powered by Google App Engine
This is Rietveld 408576698