correct displaying URLs on domain-reliability-internals page

correct displaying URLs on domain-reliability-internals page

DomainReliabilityContext::GetWebUIData() puts into dictionary URL
to the entry with name "origin", but domain_reliability_internals.html
tries to display "domain" data field as URL.

R=dbeam@chromium.org, ttuttle@chromium.org
BUG=641876
TEST=Force Domain Reliability feature and load chrome://domain-reliability-internals page
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f6c04cf1d3aac4d7bbcbb52cb2127b5ef521c73d
Cr-Commit-Position: refs/heads/master@{#421795}

[pavor, 2016-08-29 08:13:02]

Description was changed from

==========
correct displaying URLs on domain-reliability-internals page

DomainReliabilityContext::GetWebUIData() puts into dictionary URL
to the entry with name "origin", but domain_reliability_internals.html
tries to display "domain" data field as URL.

R=dbeam@chromium.org, ttuttle@chromium.org
BUG=641876
TEST=Force Domain Reliability feature and load
chrome://domain-reliability-internals page
==========

to

==========
correct displaying URLs on domain-reliability-internals page

DomainReliabilityContext::GetWebUIData() puts into dictionary URL
to the entry with name "origin", but domain_reliability_internals.html
tries to display "domain" data field as URL.

R=dbeam@chromium.org, ttuttle@chromium.org
BUG=641876
TEST=Force Domain Reliability feature and load
chrome://domain-reliability-internals page
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-08-30 01:46:44]

lgtm, is there any way you could add a test, though?

[pavor, 2016-08-30 07:25:09]

On 2016/08/30 01:46:44, Dan Beam wrote:
> lgtm, is there any way you could add a test, though?

There is a way I believe if I add some ids to elements on
domains_reliability_internals page and then do a test where I would check their
values filled from some known WebUI data. It should catch refactoring errors if
someone will rename some data elements again, wouldn't it be an overkill though?

[Dan Beam, 2016-08-31 18:44:47]

https://codereview.chromium.org/2290563002/diff/1/chrome/browser/resources/do...
File chrome/browser/resources/domain_reliability_internals.html (right):

https://codereview.chromium.org/2290563002/diff/1/chrome/browser/resources/do...
chrome/browser/resources/domain_reliability_internals.html:23: <h2
jscontent="origin"></h2>
can you use assert(origin) or jsdisplay="assert(origin)"?

[pavor, 2016-09-29 09:45:10]

On 2016/08/31 18:44:47, Dan Beam wrote:
>
https://codereview.chromium.org/2290563002/diff/1/chrome/browser/resources/do...
> File chrome/browser/resources/domain_reliability_internals.html (right):
> 
>
https://codereview.chromium.org/2290563002/diff/1/chrome/browser/resources/do...
> chrome/browser/resources/domain_reliability_internals.html:23: <h2
> jscontent="origin"></h2>
> can you use assert(origin) or jsdisplay="assert(origin)"?

IMO that would change the way production code works only just to make unit tests
work for this page. To implement this I need a specific assert function that
returns its argument if it is non-null and throws if it null. If that approach
was unified and used on other template html pages inside chrome codebase, I
would definitely use it. But I don't think that it is necessary right now for
this particular page.

[pavor, 2016-09-29 09:45:17]

The CQ bit was checked by pavor@yandex-team.ru

[commit-bot: I haz the power, 2016-09-29 09:45:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 10:41:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-29 10:42:53]

Description was changed from

==========
correct displaying URLs on domain-reliability-internals page

DomainReliabilityContext::GetWebUIData() puts into dictionary URL
to the entry with name "origin", but domain_reliability_internals.html
tries to display "domain" data field as URL.

R=dbeam@chromium.org, ttuttle@chromium.org
BUG=641876
TEST=Force Domain Reliability feature and load
chrome://domain-reliability-internals page
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
correct displaying URLs on domain-reliability-internals page

DomainReliabilityContext::GetWebUIData() puts into dictionary URL
to the entry with name "origin", but domain_reliability_internals.html
tries to display "domain" data field as URL.

R=dbeam@chromium.org, ttuttle@chromium.org
BUG=641876
TEST=Force Domain Reliability feature and load
chrome://domain-reliability-internals page
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f6c04cf1d3aac4d7bbcbb52cb2127b5ef521c73d
Cr-Commit-Position: refs/heads/master@{#421795}
==========

[commit-bot: I haz the power, 2016-09-29 10:42:54]

Patchset 1 (id:??) landed as
https://crrev.com/f6c04cf1d3aac4d7bbcbb52cb2127b5ef521c73d
Cr-Commit-Position: refs/heads/master@{#421795}

[Dan Beam, 2016-09-29 17:09:26]

https://codereview.chromium.org/2290563002/diff/1/chrome/browser/resources/do...
File chrome/browser/resources/domain_reliability_internals.html (right):

https://codereview.chromium.org/2290563002/diff/1/chrome/browser/resources/do...
chrome/browser/resources/domain_reliability_internals.html:23: <h2
jscontent="origin"></h2>
On 2016/08/31 18:44:47, Dan Beam wrote:
> can you use assert(origin) or jsdisplay="assert(origin)"?

note: assert() does return what you've given to it (if it's not falsey, in which
case it throws)