Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2290553004: DevTools: Record EvaluateScript event for workers. (Closed)

Created:
4 years, 3 months ago by alph
Modified:
4 years, 3 months ago
Reviewers:
haraken, caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Record EvaluateScript event for workers. Committed: https://crrev.com/aeeadb3e79a6880360bedc6414183cc4102871af Cr-Commit-Position: refs/heads/master@{#415245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/inspector/tracing/worker-js-frames.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/worker-js-frames-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
alph
4 years, 3 months ago (2016-08-29 20:38:03 UTC) #2
caseq
lgtm
4 years, 3 months ago (2016-08-29 23:46:39 UTC) #3
alph
Pavel, could you please do the owners review.
4 years, 3 months ago (2016-08-30 01:06:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290553004/1
4 years, 3 months ago (2016-08-30 02:11:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/248744)
4 years, 3 months ago (2016-08-30 03:42:43 UTC) #9
haraken
bindings/ owner LGTM
4 years, 3 months ago (2016-08-30 03:44:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290553004/1
4 years, 3 months ago (2016-08-30 08:33:48 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 08:37:56 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 08:39:49 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aeeadb3e79a6880360bedc6414183cc4102871af
Cr-Commit-Position: refs/heads/master@{#415245}

Powered by Google App Engine
This is Rietveld 408576698